Fix Voronoi diagrams in orx-triangulation #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add DelaunayTriangulation and VoronoiDiagram classes * Add tests
Vechro
reviewed
Jul 20, 2022
|
@edwinRNDR I had a rough look at it, but didn't have the opportunity to try it. I'll finish the process of getting the Delaunator library into Maven, so you can create a PR there for the library specific changes, what do you think of this? |
Co-authored-by: Edwin Jakobs <edwin@rndr.studio>
� Conflicts: � build.gradle � settings.gradle.kts
|
BTW the example images are not visible in https://github.com/openrndr/orx/tree/master/orx-jvm/orx-triangulation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces robust predicates to improve tessellation stability and fixes several bugs introduced in the conversion from Javascript to Kotlin.
Despite my numerous efforts at getting this to work identically to the javascript version I have some artefacts that I could only work around by introducing a small bias to
orient2d. This feels wrong.Future effort will go to a common Kotlin / multi platform implementation.