Fix CI failure #134
Merged
Fix CI failure #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
error: assigning the result of `ToOwned::to_owned()` may be inefficient
--> src/link.rs:236:9
|
236 | self.name = name.to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `name.clone_into(&mut self.name)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `-D clippy::assigning-clones` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::assigning_clones)]`
```
```
error: unnecessary use of `get(&j.parent.link).is_some()`
--> src/urdf.rs:274:41
|
274 | if parent_link_name_to_node.get(&j.parent.link).is_some() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&j.parent.link)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
= note: `-D clippy::unnecessary-get-then-check` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_get_then_check)]`
error: unnecessary use of `get(&l.name).is_none()`
--> src/urdf.rs:365:16
|
365 | if map.get(&l.name).is_none() {
| ----^^^^^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!map.contains_key(&l.name)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
error: unnecessary use of `get(&l.name).is_none()`
--> src/urdf.rs:378:16
|
378 | if map.get(&l.name).is_none() {
| ----^^^^^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!map.contains_key(&l.name)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
```
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
+ Coverage 66.47% 67.37% +0.90%
==========================================
Files 13 13
Lines 1578 1548 -30
Branches 1578 1548 -30
==========================================
- Hits 1049 1043 -6
+ Misses 498 486 -12
+ Partials 31 19 -12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.