Make Tree, Node, and ExtendStatus private #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
taiki-e/priv
branch
from
a81a097
to
0632bf5
Compare
taiki-e
force-pushed
the
taiki-e/priv
branch
from
0632bf5
to
8b9640f
Compare
OTL
approved these changes
Jan 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know, no one is using these public APIs, and no one has concrete plans to use them.
So, for now, I would like to make these private. We can make them public again when someone needs it.
Replaces #29
This also removes unused fields and reduces allocation in Tree.
This also removes kdtree from public dependencies.
NOTE: This is a breaking change.