Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write_to_string exports with "Robot" tag instead of "robot" #80

Closed
audrow opened this issue Aug 8, 2023 · 3 comments · Fixed by #81
Closed

write_to_string exports with "Robot" tag instead of "robot" #80

audrow opened this issue Aug 8, 2023 · 3 comments · Fixed by #81

Comments

@audrow
Copy link

audrow commented Aug 8, 2023 •
edited
Loading

The write_to_string function uses uppercase "Robot" tag. This can't be used directly by Rviz (and probably other ROS tools) without converting to lowercase "robot" tag.

Simple work around:

urdf_rs::write_to_string(&urdf)?.replace("<Robot", "<robot").replace("</Robot", "</robot")
@taiki-e
Copy link
Contributor

taiki-e commented Aug 9, 2023 •
edited
Loading

Oh, this is another bug introduced in #64. We should probably use #[yaserde(root = "robot")]#[yaserde(rename = "robot")] on the Robot struct.

Thanks for the report!

taiki-e added a commit that referenced this issue Aug 18, 2023
@taiki-e
Fix yaserde serialization of Robot
3a6b0f7 
Fixes #80
@taiki-e taiki-e mentioned this issue Aug 18, 2023
Merged
taiki-e added a commit that referenced this issue Aug 18, 2023
@taiki-e
Fix yaserde serialization of Robot
d543895 
Fixes #80
@taiki-e taiki-e mentioned this issue Aug 18, 2023
Merged
@taiki-e
Copy link
Contributor

taiki-e commented Aug 18, 2023

Fixed in 0.7.3.

@audrow
Copy link
Author

audrow commented Aug 21, 2023

Nice, thank you for the quick fix!

@taiki-e taiki-e mentioned this issue Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix yaserde serialization of Robot openrr/urdf-rs
2 participants
@audrow @taiki-e