Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new command-line argument to pass arguments to xacro #197

Merged
merged 9 commits into from
Feb 27, 2023

Conversation

JafarAbdi
Copy link
Contributor

Depends on openrr/urdf-rs#61

Make it so it's possible to load xacro files that expects arguments.

Copy link
Collaborator

@OTL OTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/utils.rs Outdated Show resolved Hide resolved
Co-authored-by: Takashi Ogura <t.ogura@gmail.com>
src/utils.rs Outdated Show resolved Hide resolved
@JafarAbdi
Copy link
Contributor Author

Oops, looks like the main branch has been broken for a while, I can't see https://openrr.github.io/urdf-viz/?urdf=https://raw.githubusercontent.com/openrr/urdf-viz/main/sample.urdf -- Last commit should fix it.

I still have no idea why macos is failing, though

@JafarAbdi JafarAbdi closed this Feb 22, 2023
@JafarAbdi JafarAbdi reopened this Feb 22, 2023
@OTL OTL requested a review from taiki-e February 22, 2023 08:43
@OTL
Copy link
Collaborator

OTL commented Feb 22, 2023

Thanks! @taiki-e is this OK?

@taiki-e taiki-e merged commit da8d1b0 into openrr:main Feb 27, 2023
@JafarAbdi JafarAbdi deleted the feature/xacro-args branch February 27, 2023 10:11
@taiki-e taiki-e mentioned this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants