Fix circular redirects caused by wildcards in paths #4633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jongmassey
force-pushed
the
Jongmassey/Pages-with-Redirect-Error
branch
from
7c54f0e
to
dcaf726
Compare
StevenMaude
reviewed
Oct 1, 2024
We allow underscores in project and workspace names. When finding redirects, we search for redirects whose `old_url` is at the beginning of the requested URL. Previous approaches hand-constructed the SQL WHERE clause with a LIKE operator which was buggy due to underscores being LIKE wildcards. With this approach, Django generates the WHERE clause with all the necessary escaping of characters in `old_url` that could be interpreted as wildcards. Co-authored-by: Mike Kelly <mike.kelly@thedatalab.org>
Jongmassey
force-pushed
the
Jongmassey/Pages-with-Redirect-Error
branch
from
dcaf726
to
5fe99ae
Compare
StevenMaude
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4545