use https for submodules #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why, though? |
|
On Tue, Dec 26, 2017 at 04:46:29PM +0000, Chow Loong Jin wrote:
Why, though?
To avoid the MITM vulnerability.
…--
() ascii ribbon campaign - against html mail
/\ http://arc.pasp.de/ - against proprietary attachments
|
|
I don't think there's much chance for active MITM here (commit SHAs of submodules are stored in the tree of the parent repo), but I guess there's no harm in accepting this. Pushing over https is annoying, but cloning over https isn't too bad. |
|
On Tue, Dec 26, 2017 at 08:59:08AM -0800, Chow Loong Jin wrote:
I don't think there's much chance for active MITM here (commit SHAs of submodules are stored in the tree of the parent repo), but I guess there's no harm in accepting this. Pushing over https is annoying, but cloning over https isn't too bad.
Sounds legit. Gentoo is complaining anyway when it recursively fetches git repos for building :/
…--
() ascii ribbon campaign - against html mail
/\ http://arc.pasp.de/ - against proprietary attachments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.