regular_shapes: Avoid the circle trick

[rockstorm101]

As is stated in the very own manual of OpenSCAD [1], generating polygons
using the circle function is a trick that should be avoided.

[1] https://en.wikibooks.org/wiki/OpenSCAD_User_Manual/2D_Primitives#regular_polygon

[rockstorm101]

Also, would you accept renaming from "reg_polygon" to "regular_polygon"? Since standard two-word functions such as "rotate_extrude" or "linear_extrude" are not abbreviated.

[GilesBathgate]

When I originally wrote it I was intending to abstract away 'the trick', so that it could be avoided. Thinking about it, it may well have been me that wrote the paragraph on the wiki too.

As for renaming it regular_polygon, it's fine to create a wrapper function, but deleting it will break anyone's existing files.

[rockstorm101]

When I originally wrote it I was intending to abstract away 'the trick', so that it could be avoided. Thinking about it, it may well have been me that wrote the paragraph on the wiki too.

Haha, cool.

As for renaming it regular_polygon, it's fine to create a wrapper function, but deleting it will break anyone's existing files.

Of course, yeah, the idea was to make the old one a wrapper to the new and add a deprecation warning.

[hyperair]

Yeah, trying to preserve backward compatibility is the reason the dev branch hasn't been merged after so long.