Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open scd components #1542

Closed
wants to merge 25 commits into from
Closed

Open scd components #1542

wants to merge 25 commits into from

Conversation

pascalwilbrink
Copy link
Member

No description provided.

@pascalwilbrink pascalwilbrink marked this pull request as ready for review June 10, 2024 12:42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README should be specific to the components project, something small that only states its purpose and how to install. Maybe something like this:

@openscd/components

This project contains the code for various UI components that are essential for the functionality of OpenSCD plugins and addons. These components are designed to be reusable and modular, making it easy to integrate them into different projects.

Installation

To install the components in your project, you can use npm (or yarn). Ensure you have Node.js installed, then run:

npm install @openscd/components

License

This project is licensed under the Apache License 2.0.

© 2020-2022 OMICRON electronics GmbH, TransnetBW GmbH, Alliander N.V., and others

"name": "@openscd/components",
"version": "0.34.0",
"repository": "https://github.com/openscd/open-scd.git",
"directory": "packages/openscd",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"directory": "packages/openscd",
"directory": "packages/openscd",
Suggested change
"directory": "packages/openscd",
"directory": "packages/components",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be empty

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicated foundation file should be removed once the @openscd/wizards is developed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a follow up story to reactivate these tests

@trusz
Copy link
Member

trusz commented Jul 23, 2024

We will close the PR because it is too big to understand and go through all the changes even if they just move files around

@trusz trusz closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants