Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all the things #3157

Merged

Conversation

matyasselmeci
Copy link
Collaborator

Upgrade all dependencies to the latest; use the ~= operator (https://peps.python.org/pep-0440/#compatible-release) so we don't completely lock versions in. Update the downtime forms for WTForms 3.0 compatibility.

Copy link
Collaborator

@osg-bot osg-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSG Staff:

There was an unexpected error verifying this PR - please review.

-- OSG-BOT 💥


Output from the automerge downtime check script:


Traceback (most recent call last):
  File "/app/webapp/automerge_check.py", line 288, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/app/webapp/automerge_check.py", line 95, in main
    contacts = get_gh_contacts(GH_USER)
  File "/app/webapp/automerge_check.py", line 283, in get_gh_contacts
    contact_list = get_contacts()
  File "/app/webapp/automerge_check.py", line 277, in get_contacts
    txt = urlopen(_contacts_url).read()
  File "/usr/lib64/python3.9/urllib/request.py", line 214, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib64/python3.9/urllib/request.py", line 523, in open
    response = meth(req, response)
  File "/usr/lib64/python3.9/urllib/request.py", line 632, in http_response
    response = self.parent.error(
  File "/usr/lib64/python3.9/urllib/request.py", line 561, in error
    return self._call_chain(*args)
  File "/usr/lib64/python3.9/urllib/request.py", line 494, in _call_chain
    result = func(*args)
  File "/usr/lib64/python3.9/urllib/request.py", line 641, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 503: Service Unavailable

@matyasselmeci
Copy link
Collaborator Author

matyasselmeci commented May 24, 2023

This apparently causes booleans in XML to be rendered as true and false, not True and False which breaks our XML schema.

According to this page,

Legal values for boolean are true, false, 1 (which indicates true), and 0 (which indicates false).

so this is correct behavior from the library. We could do a post-processing step where we turn boolean True/False into "True" and "False" to keep the XML the same as before, but I'd rather just update the schema if we can get away with it...

@brianhlin
Copy link
Member

This apparently causes booleans in XML to be rendered as true and false, not True and False which breaks our XML schema.

You gotta be kidding me

We could do a post-processing step where we turn boolean True/False into "True" and "False" to keep the XML the same as before, but I'd rather just update the schema if we can get away with it...

Yeah, let's do it. Can you give our XML consumers a quick heads up? You can do it after the fact, just so that they know to look for issues

@matyasselmeci
Copy link
Collaborator Author

I updated the schema and gave the CRIC folks a heads up. Can I get an approval?

Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matyasselmeci matyasselmeci merged commit d4ed188 into opensciencegrid:master Jun 27, 2023
@matyasselmeci matyasselmeci deleted the pr/upgrade-all-the-things branch June 27, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants