NavaThread engine

[sepandhaghighi]

Reference Issues/PRs

What does this implement/fix? Explain your changes.

• engine parameter added to NavaThread class

Any other comments?

Local tests on OSs

• macOS
  • Sonoma
• Windows
  • Windows 11
• Linux
  • Ubuntu 22.04

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (0d81ddf) to head (ff58945).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev      #51   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files           4        4           
  Lines         165      165           
  Branches       24       24           
=======================================
  Hits          157      157           
  Misses          2        2           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sadrasabouri]

LGTM, I will check it on MacOS too soon.
JFR: On Ubuntu when running with Engine.WINSOUND and Engine.AFPLAY errors are different in async_mode=True mode. I guess it's due the different call of these engines.

Engine.AFPLAY:

FileNotFoundError: [Errno 2] No such file or directory: 'afplay'

Engine.WINSOUND:

nava.errors.NavaBaseError: Sound can not play due to some issues.

[sepandhaghighi]

LGTM, I will check it on MacOS too soon. JFR: On Ubuntu when running with Engine.WINSOUND and Engine.AFPLAY errors are different in async_mode=True mode. I guess it's due the different call of these engines.

Engine.AFPLAY:

FileNotFoundError: [Errno 2] No such file or directory: 'afplay'

Engine.WINSOUND:

nava.errors.NavaBaseError: Sound can not play due to some issues.

@sadrasabouri You are right 💯
This difference between errors is related to the location of the function call, whether in the main thread or in another thread.
I will address this problem in a separate pull request. 🔥

[sadrasabouri]

Tested on MacOS. Ready to go.