Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make level check stricter #332

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Make level check stricter #332

merged 2 commits into from
Aug 3, 2021

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Aug 3, 2021

Pull request

Please confirm that this pull request has done the following:

  • Tests added (N/A)
  • Documentation added (where applicable) (N/A)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added
  • Fix up tests #331

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

@znicholls
Copy link
Collaborator Author

Pretty minor but hopefully makes sense @lewisjared

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #332 (13c9143) into master (c9bdd61) will increase coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   93.20%   93.25%   +0.04%     
==========================================
  Files          20       20              
  Lines        2591     2594       +3     
  Branches      513      515       +2     
==========================================
+ Hits         2415     2419       +4     
  Misses        111      111              
+ Partials       65       64       -1     
Impacted Files Coverage Δ
pymagicc/core.py 88.08% <0.00%> (ø)
pymagicc/io/compact.py 87.50% <100.00%> (+0.32%) ⬆️
pymagicc/io/scen.py 97.66% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c91f2...13c9143. Read the comment docs.

@znicholls znicholls merged commit 46f1bb4 into master Aug 3, 2021
@znicholls znicholls deleted the warning-hotfix branch August 3, 2021 11:02
@znicholls
Copy link
Collaborator Author

Ignoring codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants