Test Eurostat Example

[Tungurahua]

Added an example of Eurostat data to the inst/data. As Eurostat provides SDMX2.0 only via SOAP I added the file locally. REST is only available for SDMX 2.1. The file is used from the readSDMX examples

In addition I noted that moving the documentation to Roxygen is on the issues list, so I did this change for readSDMX.R

Any comments welcome.

[briatte]

Will check it out as soon as I come back to France!

Also, I discovered this related package yesterday.

[eblondel]

For the Roxygen, i prefer not mixing it with the Eurostat dataset testing. I didn't have look yet enough in Roxygen, and if we move the Rdoc with it it will be probably later. At now, the Rdoc will not be generated automatically with Roxygen annotations. It would be good if you could revert or remove the commits on this, and update the ticket only targeting Eurostat test. We can further discuss the "oxygenization" in the ticket i've created.

• what you want here is to provide a sample dataset only to make it available for the R doc examples. I'm fine with this, but at now consider to add it directly in the Rdoc file.
• did you find any error when applying readSDMX? Initially, i've set up the inst/data mainly to use as test resources for each test. I think it would be useful to write a test for this new sample, and if it fails see what's wrong in order to fix the bugs.

[antagomir]

Hi, very interesting. I should check in more detail the connection to our eurostat R package which is in beta phase now. As far as I understand the rsdmx is a generic interface package which just gives an example with eurostat data but is more generally applicable. We might be able to utilize this more in the eurostat package and avoid unnecessary overlap, merge the efforts where useful.

[eblondel]

Hello @antagomir , yes indeed the rsdmx intends to be a generic interface to read SDMX-ML documents. Testing it with EuroStat data was introduced with this request. Until now the rsdmx has been successfully tested and used on FAO & OECD SDMX web-services. Indeed it would be great if you consider its use in packages such as eurostat. Your comments & contributions are also welcome.

As suggested here, the Eurostat example could added as code sample for the Rdoc, and probably a unit test will be based on it.

[Tungurahua]

Following @eblondel comment I rolled back the roxygen documentation so reading Eurostat SDMX is the main topic of this branch.

The documentation of Eurostat webservices is here. However, I am unsure if an implementation of the webservices should be part of rsdmx. What do you think?

[Tungurahua]

@eblondel regarding errors applying readSDMX - there have been none. The data is parsed as expected. I will look into formalizing this as a test. However, I need to familiarize with teststhatfirst.

[eblondel]

Good, however it seems the travis build failed for the package...
Can you do the following:

• add <?xml version="1.0" encoding="UTF-8"?> starting the xml file
• there is a typo in the example code (misssing "S" of "SDMX" in xml filename)
• in the example readSDMX, can you replace F by FALSE (it seems Travis build doesn't like it)

For the test, if you want, i can add it, no problem

[Tungurahua]

Done. Thanks for pointing out the issues.

I also added a test for the Eurostat example by running the parsed results against a dputof the expected dataframe. I don't know if that's a sensible way of doing things. Any suggestions for improvement are welcome.