Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start-opensearch action #190

Closed
wants to merge 2 commits into from

Conversation

derek-ho
Copy link

@derek-ho derek-ho commented Feb 21, 2024

Description

This PR adds a start-opensearch action to this shared repo. There are many instances of plugins in their own CI spinning up their own opensearches to test against, and there is a lot of duplicate code out there.

Examples:
https://github.com/opensearch-project/security/blob/main/.github/actions/start-opensearch-with-one-plugin/action.yml
https://github.com/opensearch-project/security-dashboards-plugin/blob/main/.github/actions/run-cypress-tests/action.yml#L38
https://github.com/opensearch-project/dashboards-observability/blob/main/.github/workflows/ftr-e2e-dashboards-observability-test.yml#L49

I would like to get some maintainers views on the path forward to getting this in and used in repos across the project.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository serves as a focal point for practices that apply to all repositories in OpenSearch, this GitHub action seems to fill a useful role - but that role does not apply to the project website, data prepper, or many other non-plugin projects.

There has been discussion about how/where these kinds of tools go

I suspect managing your own repo for an individual GitHub Action will be the fastest way to get started and then migrate if/when there is a better home.

Other areas to consider, there is a template for all plugins that might make sense from a centralization approach that best fits this use case.


I don't think there is a clear path forward for this pull request, but I'll keep it open for a week so others can comment and provide guidance - thanks @derek-ho

@dblock
Copy link
Member

dblock commented Feb 24, 2024

Another option is https://github.com/opensearch-project/opensearch-plugins. But I agree that a standalone action published to the GitHub Actions marketplace is probably best.

I propose we close this without merging?

@derek-ho
Copy link
Author

derek-ho commented Feb 26, 2024

Sure, closing. For reference I created the proposed action(s) under my own github

@derek-ho derek-ho closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants