Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement][Distribution] Support generating extracted dirs of binaries alongside tar/deb/rpm...... #1384

Open
peterzhuamazon opened this issue Mar 24, 2022 · 5 comments

Comments

@peterzhuamazon
Copy link
Member

Similar to opensearch-project/OpenSearch#2571.

We want core dashboards to be able to have extracted binaries, not only tar/deb/rpm that is packaged already.

Tar example, currently support in OS:

# Run this task:
./gradlew distribution:archives:linux-tar:build

# We get:
~/OpenSearch/distribution/archives/linux-tar/build/distributions
opensearch-min-1.3.0-linux-x64.tar.gz

~/OpenSearch/distribution/archives/linux-tar/build/tar-extracted/opensearch-1.3.0
bin  config  jdk  lib  LICENSE.txt  logs  modules  NOTICE.txt  plugins  README.md

Rpm example, currently support in OS:

# Run this task:
./gradlew distribution:packages:rpm:build

# We get:
~/OpenSearch/distribution/packages/rpm/build/distributions
opensearch-min-1.3.0.x86_64.rpm

~/OpenSearch/distribution/packages/rpm/build/extracted/rpm-extracted
etc  usr  var

~/OpenSearch/distribution/packages/rpm/build/extracted/rpm-extracted/usr/share/opensearch
bin  jdk  lib  LICENSE.txt  modules  NOTICE.txt  plugins  README.md

We hope dashboards core can also support this.

Thanks.

@bbarani
Copy link
Member

bbarani commented Mar 24, 2022

@seraphjiang @kavilla Can you please look in to this issue? This is a blocker for creating RPM artifacts.

@kavilla
Copy link
Member

kavilla commented Mar 24, 2022

@bbarani, @peterzhuamazon

Could you provide the reason at why this is a blocker for RPM artifacts? Can the build repo not support it during the assemble workflow? Seems like for distributions of linux x64 and arm64 that has been the standard and the rpm artifact is available extract.

@bbarani
Copy link
Member

bbarani commented Mar 25, 2022

@kavilla We are working with core team on a new process for OpenSearch to directly take the extracted files, install plugins, then use tar/rpmbuild/zip to create the final bundle. This requires core to provide the extracted files directly, as this is the logical process to proceed.

The old process is a messy way to extract the core tar/rpm/zip then package them back, especially in rpm, the cpio utility we are using is not able to identify symlink and cause a lot of error in the extraction process.

More info can be found here: opensearch-project/OpenSearch#2517

We would like to follow the new process for the Dashboards in order to use the common RPM generation code to support dashboards package as well.

CC: @CEHENKLE @seanneumann @seraphjiang

@bbarani
Copy link
Member

bbarani commented Mar 25, 2022

We are facing some issues in our new plan. @peterzhuamazon will update this thread with more details soon

@kavilla
Copy link
Member

kavilla commented Mar 25, 2022

I see it's originally based on the issue from OpenSearch. Does OpenSearch Dashboards have a same issue? Also in the issue there is a long term and short term plan. To unblock, for OpenSearch Dashboards could we go with the short term plan and then when a maintainer has some availability we can assign? Otherwise, we could provide guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants