[Deangular] OSD without angular #5086

ashwin-pc · 2023-09-21T20:28:03Z

Description

Removes Angular from the OpenSearch Dashboards and all related angular dependencies.

Issues Resolved

mostly closes #1560
closes #1906

Screenshot

Testing the changes

OSD should work as expected without any issues

Check List

codecov · 2023-09-21T23:32:47Z

Codecov Report

Merging #5086 (ed2672a) into main (eec3ed7) will increase coverage by 0.27%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5086      +/-   ##
==========================================
+ Coverage   66.50%   66.77%   +0.27%     
==========================================
  Files        3403     3278     -125     
  Lines       65026    62981    -2045     
  Branches    10401    10027     -374     
==========================================
- Hits        43245    42057    -1188     
+ Misses      19293    18459     -834     
+ Partials     2488     2465      -23

Flag	Coverage Δ
Linux_1	`35.31% <0.00%> (+0.49%)`	⬆️
Linux_2	`55.23% <ø> (-0.08%)`	⬇️
Linux_3	`43.77% <ø> (-0.85%)`	⬇️
Linux_4	`35.43% <ø> (+0.54%)`	⬆️
Windows_1	`35.33% <0.00%> (+0.49%)`	⬆️
Windows_2	`55.20% <ø> (-0.08%)`	⬇️
Windows_3	`43.76% <ø> (-0.85%)`	⬇️
Windows_4	`35.44% <ø> (+0.54%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/osd-ui-shared-deps/index.js	`100.00% <ø> (ø)`
src/plugins/dashboard/public/plugin.tsx	`0.00% <ø> (ø)`
...ugins/data/common/search/aggs/utils/prop_filter.ts	`100.00% <ø> (ø)`
...s/data/common/search/aggs/utils/to_angular_json.ts	`0.00% <ø> (ø)`
.../data_explorer/public/components/sidebar/index.tsx	`3.12% <ø> (ø)`
src/plugins/discover/common/index.ts	`100.00% <ø> (ø)`
...n/components/doc_viewer_links/doc_viewer_links.tsx	`100.00% <ø> (ø)`
.../application/components/sidebar/discover_field.tsx	`84.84% <ø> (ø)`
...rc/plugins/discover/public/embeddable/constants.ts	`100.00% <ø> (ø)`
src/plugins/discover/public/index.ts	`0.00% <ø> (ø)`
... and 3 more

... and 33 files with indirect coverage changes

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve #4233 --------- Signed-off-by: ananzh <ananzh@amazon.com>

…5060) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* delete legacy discover functional tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove discover folder in config file Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve #5098 #5058 Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve #5103 Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* fix1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix 1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix anchor test Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix cigroup1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

… filtering (#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

…luginPaths (#5080) Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fixes search on load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve #5129 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * restore _discover_navigation Signed-off-by: Anan Zhuang <ananzh@amazon.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com>

…gacy (#5085) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <chyltonreed@gmail.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com>

kavilla · 2023-09-28T06:19:40Z

I think ciGroup1 for build and test failed the linter step if we want to fix?

kavilla · 2023-09-28T10:48:22Z

Barring the linter failer, I think it's good to go to bake. I was clicking around trying weird workflows and it is working as expected.

Awesome \m/

Example: Dashboards required the bootstrap Angular for Discover otherwise it wouldn't render the Discover.

Tmrw I will run the build repo script with the plugins but I don't think that should block this PR once the linter is fixed.

* Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * followup fixes from #5085 Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

ananzh · 2023-09-29T17:30:15Z

I have reviewed this in the feature branch. We also opened issues for existing bugs and un-updated documents.

ashwin-pc · 2023-09-29T18:36:37Z

All cypress test failures are unrelated to the PR, there is a cypress test issue in main as well. Changelog will be added in a followup PR and linked to this PR

opensearch-trigger-bot · 2023-09-29T18:39:17Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5086-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0557ab130dbdb933555d79aad6c4fff99a90de92
# Push it to GitHub
git push --set-upstream origin backport/backport-5086-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5086-to-2.x.

github-actions · 2023-09-29T19:52:39Z

[MANUAL CYPRESS TEST RUN RESULTS]

❌ Cypress test run failed!

Inputs:

Source repo: opensearch-project/OpenSearch-Dashboards
Source branch: ````
Test repo: abbyhu2000/opensearch-dashboards-functional-test
Test branch: fix_deangular

Test spec:
cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/vis_*,cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_sanity_test_spec.js,

Link to results:

https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/6360985610

* Basic working version of OSD without angular (opensearch-project#4982) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer][Discover 2.0] Implement saved search embeddable (opensearch-project#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve opensearch-project#4233 --------- Signed-off-by: ananzh <ananzh@amazon.com> * Deangular: removes angular paginate, cleanup data plugin and tilemap (opensearch-project#5060) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer] Delete legacy discover selenium tests (opensearch-project#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove discover folder in config file Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (opensearch-project#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve opensearch-project#5098 opensearch-project#5058 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (opensearch-project#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve opensearch-project#5103 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix cigroup 1 with dataGridTable helper functions (opensearch-project#5105) * fix1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix 1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix anchor test Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix cigroup1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (opensearch-project#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add data-shared-item tag (opensearch-project#5119) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (opensearch-project#5080) Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> * fix cigroup6 (opensearch-project#5125) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Search on load fix (opensearch-project#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (opensearch-project#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve opensearch-project#5129 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * restore _discover_navigation Signed-off-by: Anan Zhuang <ananzh@amazon.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Deangular: removes angular from notify and utils of opendashboards legacy (opensearch-project#5085) * Basic working version of OSD without angular (opensearch-project#4982) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <chyltonreed@gmail.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com> * [Discover] Misc fixes (opensearch-project#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * followup fixes from opensearch-project#5085 Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: ananzh <ananzh@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Co-authored-by: Cameron Reed <cameron.reed@oracle.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com> (cherry picked from commit 0557ab1) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

seanneumann · 2023-10-03T22:42:51Z

OMGOMGOMGOMG!!!!! w0000tttt!!!!

* [Deangular] OSD without angular (#5086) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer][Discover 2.0] Implement saved search embeddable (#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve #4233 --------- Signed-off-by: ananzh <ananzh@amazon.com> * Deangular: removes angular paginate, cleanup data plugin and tilemap (#5060) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer] Delete legacy discover selenium tests (#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove discover folder in config file Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve #5098 #5058 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve #5103 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix cigroup 1 with dataGridTable helper functions (#5105) * fix1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix 1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix anchor test Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix cigroup1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add data-shared-item tag (#5119) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (#5080) Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> * fix cigroup6 (#5125) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Search on load fix (#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve #5129 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * restore _discover_navigation Signed-off-by: Anan Zhuang <ananzh@amazon.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Deangular: removes angular from notify and utils of opendashboards legacy (#5085) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <chyltonreed@gmail.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com> * [Discover] Misc fixes (#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * followup fixes from #5085 Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: ananzh <ananzh@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Co-authored-by: Cameron Reed <cameron.reed@oracle.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com> (cherry picked from commit 0557ab1) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fixes snapshot Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: ananzh <ananzh@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Co-authored-by: Cameron Reed <cameron.reed@oracle.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com>

…5177)" This reverts commit ab84ea1.

…5177)" (#5198) This reverts commit ab84ea1.

* [Deangular] OSD without angular (#5086) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer][Discover 2.0] Implement saved search embeddable (#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve #4233 --------- Signed-off-by: ananzh <ananzh@amazon.com> * Deangular: removes angular paginate, cleanup data plugin and tilemap (#5060) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer] Delete legacy discover selenium tests (#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove discover folder in config file Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve #5098 #5058 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve #5103 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix cigroup 1 with dataGridTable helper functions (#5105) * fix1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix 1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix anchor test Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix cigroup1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add data-shared-item tag (#5119) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (#5080) Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> * fix cigroup6 (#5125) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Search on load fix (#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve #5129 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * restore _discover_navigation Signed-off-by: Anan Zhuang <ananzh@amazon.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Deangular: removes angular from notify and utils of opendashboards legacy (#5085) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <chyltonreed@gmail.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com> * [Discover] Misc fixes (#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * followup fixes from #5085 Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: ananzh <ananzh@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Co-authored-by: Cameron Reed <cameron.reed@oracle.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com> (cherry picked from commit 0557ab1) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fixes snapshot Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: ananzh <ananzh@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Co-authored-by: Cameron Reed <cameron.reed@oracle.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com>

github-actions bot added the distinguished-contributor label Sep 21, 2023

ashwin-pc added the de-angular de-angularize work label Sep 21, 2023

ashwin-pc and others added 4 commits September 22, 2023 22:47

Basic working version of OSD without angular (#4982)

b03d5dc

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

[Data Explorer][Discover 2.0] Implement saved search embeddable (#5081)

a081e2f

* [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve #4233 --------- Signed-off-by: ananzh <ananzh@amazon.com>

Deangular: removes angular paginate, cleanup data plugin and tilemap (#…

9e6cb52

…5060) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

abbyhu2000 force-pushed the feature/deangular branch from f14c199 to e6b9ab2 Compare September 22, 2023 22:54

ananzh and others added 3 commits September 25, 2023 11:18

[Data Explorer][Discover][Functional Test] fix ciGroup 8 (#5104)

f45e662

Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve #5103 Signed-off-by: Anan Zhuang <ananzh@amazon.com>

abbyhu2000 force-pushed the feature/deangular branch from cee9f68 to 64f6746 Compare September 26, 2023 08:55

abbyhu2000 and others added 6 commits September 26, 2023 11:03

add data-shared-item tag (#5119)

1e94295

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Modifying html tests to utilize jsx and fixing tests to include all p…

7a843e6

…luginPaths (#5080) Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>

fix cigroup6 (#5125)

c283945

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

[Discover] Search on load fix (#5112)

e050d4d

* fixes search on load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

ashwin-pc marked this pull request as ready for review September 27, 2023 18:20

ashwin-pc requested review from ananzh, kavilla, seanneumann, AMoo-Miki, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu, manasvinibs and ZilongX as code owners September 27, 2023 18:20

ashwin-pc added backport 2.x v2.11.0 labels Sep 29, 2023

ananzh approved these changes Sep 29, 2023

View reviewed changes

abbyhu2000 approved these changes Sep 29, 2023

View reviewed changes

ashwin-pc merged commit 0557ab1 into main Sep 29, 2023
94 of 108 checks passed

opensearch-trigger-bot bot added the failed backport label Sep 29, 2023

ashwin-pc mentioned this pull request Oct 2, 2023

CVE-2022-25869 (Medium) detected in angular-1.5.0.js #1906

Closed

ashwin-pc mentioned this pull request Oct 3, 2023

[Manual backport 2.x][Deangular] OSD without angular (#5086) #5177

Merged

8 tasks

joshuarrrr removed the failed backport label Oct 3, 2023

AMoo-Miki added a commit that referenced this pull request Oct 4, 2023

Revert "[Manual backport 2.x][Deangular] OSD without angular (#5086) (#…

098ae96

…5177)" This reverts commit ab84ea1.

AMoo-Miki added a commit that referenced this pull request Oct 4, 2023

Revert "[Manual backport 2.x][Deangular] OSD without angular (#5086) (#…

f257a44

…5177)" (#5198) This reverts commit ab84ea1.

ananzh mentioned this pull request Oct 4, 2023

[Manual backport 2.x][Deangular] OSD without angular (#5086) #5200

Merged

8 tasks

AlexRuiz7 mentioned this pull request Nov 17, 2023

Compatibility with OpenSearch 2.11.0 wazuh/wazuh-dashboard#113

Closed

4 tasks

joshuali925 mentioned this pull request Jul 4, 2024

[BUG] Discover no longer shows new lines in a field #7177

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Deangular] OSD without angular #5086

[Deangular] OSD without angular #5086

ashwin-pc commented Sep 21, 2023 •

edited

Loading

codecov bot commented Sep 21, 2023 •

edited

Loading

kavilla commented Sep 28, 2023

kavilla commented Sep 28, 2023 •

edited

Loading

ananzh commented Sep 29, 2023

ashwin-pc commented Sep 29, 2023

opensearch-trigger-bot bot commented Sep 29, 2023

github-actions bot commented Sep 29, 2023 •

edited

Loading

seanneumann commented Oct 3, 2023

[Deangular] OSD without angular #5086

[Deangular] OSD without angular #5086

Conversation

ashwin-pc commented Sep 21, 2023 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Check List

codecov bot commented Sep 21, 2023 • edited Loading

Codecov Report

kavilla commented Sep 28, 2023

kavilla commented Sep 28, 2023 • edited Loading

ananzh commented Sep 29, 2023

ashwin-pc commented Sep 29, 2023

opensearch-trigger-bot bot commented Sep 29, 2023

github-actions bot commented Sep 29, 2023 • edited Loading

[MANUAL CYPRESS TEST RUN RESULTS]

❌ Cypress test run failed!

Inputs:

Link to results:

seanneumann commented Oct 3, 2023

ashwin-pc commented Sep 21, 2023 •

edited

Loading

codecov bot commented Sep 21, 2023 •

edited

Loading

kavilla commented Sep 28, 2023 •

edited

Loading

github-actions bot commented Sep 29, 2023 •

edited

Loading