Upgrading mockito version in OpenSearch

[VachaShah]

Signed-off-by: Vacha Shah vachshah@amazon.com

Description

Upgrading the mockito-core version in OpenSearch from 1.9.5 to 3.11.2.

Issues Resolved

#1008

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success 95384d2

[opensearch-ci-bot]

✅   DCO Check Passed 95384d2

[opensearch-ci-bot]

✅   Gradle Precommit success 95384d2

[adnapibar]

start gradle check

[opensearch-ci-bot]

✅   Gradle Check success 95384d2
Log 354

Reports 354

[dblock]

I'm amazed that we did two major version bumps for mockito, and everything just worked!?

[VachaShah]

I'm amazed that we did two major version bumps for mockito, and everything just worked!?

Yeah the direct dependencies worked fine for the upgrade.

[vrozov]

It does not look that the change updates mockito version globally on the OpenSearch project. The change is local to build-tools module. The mocking framework is provided by org.elasticsearch:securemock:1.2 that is based on the old 1.9.5 mockito-core version.

[VachaShah]

It does not look that the change updates mockito version globally on the OpenSearch project. The change is local to build-tools module. The mocking framework is provided by org.elasticsearch:securemock:1.2 that is based on the old 1.9.5 mockito-core version.

Yes the securemock update is part of issue #114. This PR is to upgrade the direct dependency for mockito.

[vrozov]

IMO, it is confusing to have two different versions (2 major versions apart) in a single project. Will it be better to upgrade both dependencies at the same time or use the same securemock dependency in all modules?

[vrozov]

The dependency seems to be used only by PluginBuildPluginTests where mockito is used simply to mock BwcVersions class without mocking any of its methods. It seems that such usage can be replaced with null.

[VachaShah]

IMO, it is confusing to have two different versions (2 major versions apart) in a single project. Will it be better to upgrade both dependencies at the same time or use the same securemock dependency in all modules?

You are right, we can do this as part of securemock. I will close this PR.