Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point deprecated settings to the new location. #10522

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

msfroh
Copy link
Collaborator

@msfroh msfroh commented Oct 10, 2023

Description

I was looking through some cluster settings, stumbled across the search back-pressure settings, saw they were deprecated, and the Javadoc alluded to some myserious new settings.

I'm adding links to the class with the new settings to help future developers.

Related Issues

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Compatibility status:

Checks if related components are compatible with change a645e7c

Incompatible components

Incompatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

I was looking through some cluster settings, stumbled across the search
back-pressure settings, saw they were deprecated, and the Javadoc
alluded to some myserious new settings.

I'm adding links to the class with the new settings to help future
developers.

Signed-off-by: Michael Froh <froh@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #10522 (a645e7c) into main (6c02261) will increase coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #10522      +/-   ##
============================================
+ Coverage     71.12%   71.22%   +0.10%     
- Complexity    58391    58418      +27     
============================================
  Files          4845     4845              
  Lines        275335   275335              
  Branches      40088    40088              
============================================
+ Hits         195827   196106     +279     
+ Misses        63147    62810     -337     
- Partials      16361    16419      +58     
Files Coverage Δ
...kpressure/settings/SearchBackpressureSettings.java 92.59% <ø> (ø)

... and 449 files with indirect coverage changes

@msfroh msfroh merged commit 1447d75 into opensearch-project:main Oct 12, 2023
16 checks passed
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 19, 2023
)

I was looking through some cluster settings, stumbled across the search
back-pressure settings, saw they were deprecated, and the Javadoc
alluded to some myserious new settings.

I'm adding links to the class with the new settings to help future
developers.

Signed-off-by: Michael Froh <froh@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
)

I was looking through some cluster settings, stumbled across the search
back-pressure settings, saw they were deprecated, and the Javadoc
alluded to some myserious new settings.

I'm adding links to the class with the new settings to help future
developers.

Signed-off-by: Michael Froh <froh@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
)

I was looking through some cluster settings, stumbled across the search
back-pressure settings, saw they were deprecated, and the Javadoc
alluded to some myserious new settings.

I'm adding links to the class with the new settings to help future
developers.

Signed-off-by: Michael Froh <froh@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants