added placeholder change for metrics picker #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
sumukhswamy
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
anirudha and
paulstn
as code owners
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
sumukhswamy
commented
Jun 12, 2024
| @@ -17,8 +17,8 @@ export const DataSourcePicker = ({ | |||
| selectedDataSource, | |||
| setSelectedDataSource, | |||
| }: DataSourcePickerMenuProps) => { | |||
| const onChange = (selectedDataSource) => { | |||
| setSelectedDataSource(selectedDataSource); | |||
YANG-DB
approved these changes
Jun 12, 2024
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
sumukhswamy
force-pushed
the
fix-placeholder
branch
from
507aa6e
to
b3b3297
Compare
ps48
approved these changes
Jun 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
* added placeholder change for metrics picker Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated release notes Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated tests Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> (cherry picked from commit 3da9814) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
* added placeholder change for metrics picker Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated release notes Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated tests Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> (cherry picked from commit 3da9814) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
YANG-DB
pushed a commit
that referenced
this pull request
Jun 12, 2024
* added placeholder change for metrics picker * updated release notes * updated tests --------- (cherry picked from commit 3da9814) Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sumukhswamy
added a commit
that referenced
this pull request
Jun 12, 2024
* added placeholder change for metrics picker * updated release notes * updated tests --------- (cherry picked from commit 3da9814) Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sumukh Swamy <sumukhhs@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed placeholder from data source to metric source
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.