Initial version of relevance tools with Search Comparison UI #5
Conversation
Signed-off-by: Mingkun Ma <mingkunm@amazon.com>
| export const CreateIndex = () => { | ||
| return ( | ||
| <> | ||
| <Header /> | ||
| <EuiPageBody> | ||
| <EuiEmptyPrompt | ||
| title={<h2>Create an index to start comparing search results. </h2>} | ||
| body={ | ||
| <p> | ||
| Before you can query data, you have to index it.{' '} | ||
| <EuiLink>Learn how to index your data.</EuiLink> | ||
| </p> | ||
| } | ||
| /> | ||
| </EuiPageBody> | ||
| </> | ||
| ); |
There was a problem hiding this comment.
Is this going to be part of the final plugin? Or was this copied over from somewhere?
In practice, I don't think anyone would want to use the query comparison plugin to create a new index.
There was a problem hiding this comment.
This page is from the mock. User will get into this page if there is no index exists.
There was a problem hiding this comment.
Agreed about this in practice, @msfroh, but someone may find their way to the comparison plugin without indexing anything in some odd way so the UI should account for that. Can we resolve this as is?
There was a problem hiding this comment.
Can we resolve this as is?
The only change I might make would be renaming the file to something like no_available_indexes.tsx. The purpose of the page isn't to create an index, but rather to serve a useful error page if there are no indexes.
There was a problem hiding this comment.
The only change I might make would be renaming the file to something like
no_available_indexes.tsx.
I agree with the new file name.
Speaking with available indexes, should we let users select all indexes returned from this call? I saw individual index has health and status attributes. Do we want to display all of them in Select Index Dropdown?
There was a problem hiding this comment.
I saw individual index has health and status attributes. Do we want to display all of them in Select Index Dropdown?
I think for now, we can keep it simple and show all indices returned from /_cat/indices. If an index is unable to handle a search request, we should surface an error. An index is "red" state is not usual, so IMO we don't need to worry about it too much for now.
In the long run, maybe we'll hide the indexes that start with . by default? Again, not something I would worry about for now.
public/components/query_compare/search_result/result_components/result_grid_component.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Mingkun Ma <mingkunm@amazon.com>
Signed-off-by: Mingkun Ma <mingkunm@amazon.com>
Signed-off-by: Mingkun Ma <mingkunm@amazon.com>
Signed-off-by: Mingkun Ma <mingkunm@amazon.com>
| const [querqyResult1, setQuerqyResult1] = useState({}); | ||
| const [querqyResult2, setQuerqyResult2] = useState({}); |
There was a problem hiding this comment.
Can we find/replace all occurrences of querqyResult with queryResult?
Given that there is a thing called Querqy, this apparent typo is confusing.
Signed-off-by: Mingkun Ma <mingkunm@amazon.com>
macohen
changed the title
Signed-off-by: Mingkun Ma mingkunm@amazon.com
Description
Add basic mocks, types, service, etc.
Note
This is a kick-off PR, and doesn't include the most up-to-date Results Compare page.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.