GitHub-issue#253 : Implemented GeoIP processor integration test #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: venkataraopasyavula <venkataraopasyavula@gmail.com>
venkataraopasyavula
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
Signed-off-by: venkataraopasyavula <venkataraopasyavula@gmail.com>
kkondaka
reviewed
Jul 7, 2023
| String cityUrl = "https://download.maxmind.com/app/geoip_download?edition_id=GeoLite2-City&license_key=" + maxmindLicenseKey + URL_SUFFIX; | ||
| String countryUrl = "https://download.maxmind.com/app/geoip_download?edition_id=GeoLite2-Country&license_key=" + maxmindLicenseKey + URL_SUFFIX; | ||
|
|
||
| String pipelineConfig = " aws:\n" + |
There was a problem hiding this comment.
Usually, you can do this by Mocking the config. There are many IT.java files where you can see how to do this. Take a look at ./data-prepper-plugins/aggregate-processor/src/test/java/org/opensearch/dataprepper/plugins/processor/aggregate/AggregateProcessorIT.java
There was a problem hiding this comment.
As per David suggestion, we have added yaml input (configuration) in other plugins like S3Source.
For example in S3Source: S3SelectCSVOptionTest.java, S3ScanScanOptionsTest.java.
In case integration testing, the mocking should be avoided as much as possible.
| geoData = geoIPProcessorService.getGeoData(inetAddress, null); | ||
|
|
||
| assertThat(geoData.get("country_iso_code"), equalTo("US")); | ||
| assertThat(geoData.get("ip"), equalTo("/8.8.8.8")); |
There was a problem hiding this comment.
Why is it "/8.8.8.8" and not "8.8.8.8"?
There was a problem hiding this comment.
Updated the code to get the valid IP in PR#2925 also updated assertion statement with "8.8.8.8" instead of "/8.8.8.8".
Signed-off-by: venkataraopasyavula <venkataraopasyavula@gmail.com>
Signed-off-by: venkataraopasyavula <venkataraopasyavula@gmail.com>
oeyh
reviewed
Jul 12, 2023
There was a problem hiding this comment.
@venkataraopasyavula There's a build failure. Can you take a look?
if (IPValidationcheck.isPublicIpAddress(ipAddress)) {
^
symbol: method isPublicIpAddress(String)
location: class IPValidationcheck
/home/runner/work/data-prepper/data-prepper/data-prepper-plugins/geoip-processor/src/integrationTest/java/org/opensearch/dataprepper/plugins/processor/GeoIPProcessorUrlServiceIT.java:95: error: method getGeoData in class GeoIPProcessorService cannot be applied to given types;
geoData = geoIPProcessorService.getGeoData(inetAddress, null);
^
required: InetAddress,List<String>,ZonedDateTime
found: InetAddress,<null>
reason: actual and formal argument lists differ in length
2 errors
FAILURE: Build failed with an exception.
Signed-off-by: venkataraopasyavula <venkataraopasyavula@gmail.com>
oeyh
approved these changes
Jul 13, 2023
kkondaka
approved these changes
Jul 14, 2023
chenqi0805
pushed a commit
that referenced
this pull request
Jul 19, 2023
* GitHub-issue#253 : Implemented GeoIP processor integration test Signed-off-by: venkataraopasyavula <venkataraopasyavula@gmail.com> * GitHub-issue#253 : Implemented GeoIP processor integration test Signed-off-by: venkataraopasyavula <venkataraopasyavula@gmail.com> * GitHub-issue#253 : Implemented GeoIP processor integration test Signed-off-by: venkataraopasyavula <venkataraopasyavula@gmail.com> * GitHub-issue#253 : Implemented GeoIP processor integration test Signed-off-by: venkataraopasyavula <venkataraopasyavula@gmail.com> * GitHub-issue#253 : Implemented GeoIP processor integration test Signed-off-by: venkataraopasyavula <venkataraopasyavula@gmail.com> Signed-off-by: George Chen <qchea@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration Test
Issues Resolved
GitHub-issue #253
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.