Continue calling S3SinkService::output even if records is empty to flush stale batches #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engechas
requested review from
chenqi0805,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
dlvenable
previously approved these changes
Aug 17, 2023
| @@ -91,59 +90,48 @@ public S3SinkService(final S3SinkConfig s3SinkConfig, final BufferFactory buffer | |||
| numberOfRecordsSuccessCounter = pluginMetrics.counter(NUMBER_OF_RECORDS_FLUSHED_TO_S3_SUCCESS); | |||
| numberOfRecordsFailedCounter = pluginMetrics.counter(NUMBER_OF_RECORDS_FLUSHED_TO_S3_FAILED); | |||
| s3ObjectSizeSummary = pluginMetrics.summary(S3_OBJECTS_SIZE); | |||
|
|
|||
| reentrantLock.lock(); | |||
There was a problem hiding this comment.
I don't think we need a lock here. The constructor is called once by one thread.
There was a problem hiding this comment.
Makes sense, I wasn't sure. I'll remove this with the rebase
Signed-off-by: Chase Engelbrecht <engechas@amazon.com>
Signed-off-by: Chase Engelbrecht <engechas@amazon.com>
Signed-off-by: Chase Engelbrecht <engechas@amazon.com>
Signed-off-by: Chase Engelbrecht <engechas@amazon.com>
Signed-off-by: Chase Engelbrecht <engechas@amazon.com>
engechas
force-pushed
the
fix-abandoned
branch
from
7a472d5
to
2ea59c6
Compare
chenqi0805
approved these changes
Aug 17, 2023
dlvenable
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Any data left in the S3 sink buffer after traffic stops won't be flushed to S3 sink the threshold check is never reached again. This PR changes the behavior to continue calling
S3SinkService::outputeven if the current processing batch is empty to check if the previously buffered data should now be flushed.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.