Key value processor enhancements #4521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 6, 2024 06:19
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
asifsmohammed,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
graytaylor0
previously approved these changes
May 10, 2024
| @JsonProperty("key_value_when") | ||
| private String keyValueWhen; | ||
|
|
||
| @AssertTrue(message = "Invalid Configuration. valueGrouping option and field_delimiter_regex are mutually exclusive") |
| @@ -496,6 +586,9 @@ private Map<String, Object> executeConfigs(Map<String, Object> map) { | |||
| processed.put(pair.getKey(), pair.getValue()); | |||
| } | |||
|
|
|||
| if (keyValueProcessorConfig.getDropKeysWithNoValue()) { | |||
There was a problem hiding this comment.
Looks like there may not be unit tests for this
chenqi0805
reviewed
May 10, 2024
|
|
||
| public int findInStartGroup(final String str, int idx) { | ||
| int j = 0; | ||
| while (j < startGroupStrings.length) { |
There was a problem hiding this comment.
Is there reason not to use for loop?
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
chenqi0805
approved these changes
May 13, 2024
graytaylor0
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two new config options are added
value_grouping: true/falseThis option groups the values when values start with "(" "[" "<" "{" , single quote, double quote and "http://" and "https://"
When a value starts with one of the above mentioned strings, all the characters after that are considered part of the value until the corresponding end character is found (ie no keyvalue or field value parsing happens). If the corresponding end character is not found, an error is displayed. When this option is enabled,
field_delimiter_regexoption is not allowed. All other existing options are valid with this config option.drop_keys_with_no_value:true/falseThis option drops keys that do not have a value associated with them. This is done after
default_valuesoption is processed. Even after default values are assigned, if keys havenullvalue, they are dropped when this config option is set to trueIssues Resolved
Resolves #4447
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.