-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For [Doc] Alerting plugin RBAC - backend roles usage #1866
Conversation
Signed-off-by: alicejw <alicejw@amazon.com>
Signed-off-by: alicejw <alicejw@amazon.com>
Signed-off-by: alicejw <alicejw@amazon.com>
Signed-off-by: alicejw <alicejw@amazon.com>
Signed-off-by: alicejw <alicejw@amazon.com>
Signed-off-by: alicejw <alicejw@amazon.com>
…ckend roles section Signed-off-by: alicejw <alicejw@amazon.com>
Signed-off-by: alicejw <alicejw@amazon.com>
thanks @lezzago ! Would you please take another look to verify the changes are correct? best regards |
Signed-off-by: alicejw <alicejw@amazon.com>
Hi @lezzago , i've made the updates. Please take a look and verify. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of short comments, otherwise LGTM.
_monitoring-plugins/alerting/api.md
Outdated
} | ||
``` | ||
|
||
To learn more about using backend roles to limit access, see [\(Advanced\) Limit access by backend role]({{site.url}}{{site.baseurl}}/monitoring-plugins/alerting/security/#advanced-limit-access-by-backend-role). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the backslashes here intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought it wouldn't render the link properly with the title in parenthesis. but tested it without, and it's fine. thanks!
|
||
- For admin users, an empty list is considered the same as removing all permissions that the user possesses. If a non-admin user passes in an empty list, that will throw an exception, because that is not allowed by non-admin users. | ||
- If the user tries to associate roles that they don't have permission to use, it will throw an exception. | ||
{: .note } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the above unordered list format correctly in your local jekyll build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_monitoring-plugins/alerting/api.md
Outdated
|
||
#### Sample request | ||
|
||
The following request creates a query-level monitor and provides two backend roles `role1` and `role2`. The section at the bottom of the request shows the line that specifies the roles with this syntax: `"rbac_roles": ["role1", "role2"]`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"... and provides two backend roles, role1
and role2
."
just a comma.
|
||
### Specify RBAC backend roles | ||
|
||
You can specify RBAC backend roles when you create or update a monitor with the Alerting API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worthwhile spelling out Rule Based Access Control here. I don't think it appears before this on the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. adding "role-based access control" with acronym in parentheses
|
||
User type | Role is specified by user or not (Y/N) | How to use the RBAC roles | ||
:--- | :--- | :--- | ||
Admin user | Yes | Remove all the backend roles associate to the monitor and then use all the specified backend roles to associate to the monitor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Remove all the backend roles associated to the monitor ..."
"associated" correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with suggestions.
Signed-off-by: alicejw <alicejw@amazon.com>
…site/issues/1810
Signed-off-by: alicejw alicejw@amazon.com
Description
How to use new RBAC role parameter to create a monitor and specify a role.
Issues Resolved
Alerting plugin RBAC
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.