Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add k-NN filter to neural search #2466

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Add k-NN filter to neural search #2466

merged 3 commits into from
Jan 24, 2023

Conversation

Naarcha-AWS
Copy link
Collaborator

Signed-off-by: Naarcha-AWS naarcha@amazon.com

Fixes #2271.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Naarcha-AWS
Add k-NN filter to search
cd672db 
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@Naarcha-AWS Naarcha-AWS added 3 - Tech review PR: Tech review in progress v2.5.0 'Issues and PRs related to version v2.5.0' release-notes PR: Include this PR in the automated release notes labels Jan 24, 2023
@Naarcha-AWS Naarcha-AWS requested a review from a team as a code owner January 24, 2023 17:50
@Naarcha-AWS
Add technical feedback
ac684f2 
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@Naarcha-AWS Naarcha-AWS added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Jan 24, 2023
@Naarcha-AWS Naarcha-AWS changed the title Add k-NN filter to search Add k-NN filter to neural search Jan 24, 2023
alicejw1
alicejw1 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@alicejw1 alicejw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
verified link to "Search with k-NN filters"

_neural-search-plugin/index.md Outdated Show resolved Hide resolved
@Naarcha-AWS @alicejw1
Update _neural-search-plugin/index.md
925d32b 
Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>
kolchfa-aws
kolchfa-aws approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naarcha-AWS Naarcha-AWS merged commit cba313d into main Jan 24, 2023
@Naarcha-AWS Naarcha-AWS deleted the 2.5-neural-search branch January 24, 2023 18:23
vagimeli pushed a commit that referenced this pull request Jan 25, 2023
@Naarcha-AWS @alicejw1 @vagimeli
Add k-NN filter to neural search (#2466)
20d4c55 
* Add k-NN filter to search

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Add technical feedback

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Update _neural-search-plugin/index.md

Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>
vagimeli added a commit that referenced this pull request Jan 26, 2023
@vagimeli
Revert "Add k-NN filter to neural search (#2466)"
b1f34ae 
This reverts commit 20d4c55.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@alicejw1 alicejw1 alicejw1 approved these changes

Assignees
No one assigned
Labels
4 - Doc review PR: Doc review in progress release-notes PR: Include this PR in the automated release notes v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Add filter functionality to neural-search docs
3 participants
@Naarcha-AWS @alicejw1 @kolchfa-aws