-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for wait_for_completion API #3458
Conversation
Signed-off-by: ariamarble <armarble@amazon.com>
Signed-off-by: ariamarble <armarble@amazon.com>
waiting on UI screenshots and UI steps |
Signed-off-by: ariamarble <armarble@amazon.com>
Signed-off-by: ariamarble <armarble@amazon.com>
Signed-off-by: ariamarble <armarble@amazon.com>
Signed-off-by: ariamarble <armarble@amazon.com>
Signed-off-by: ariamarble <armarble@amazon.com>
Signed-off-by: ariamarble <armarble@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a suggestion.
Signed-off-by: ariamarble <armarble@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ariamarble Please see my changes and apply to each duplicate instance. Let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: ariamarble <armarble@amazon.com>
* Add documentation for wait_for_completion API Signed-off-by: ariamarble <armarble@amazon.com> * draft update Signed-off-by: ariamarble <armarble@amazon.com> * small comment Signed-off-by: ariamarble <armarble@amazon.com> * page and toc updates Signed-off-by: ariamarble <armarble@amazon.com> * page updates Signed-off-by: ariamarble <armarble@amazon.com> * final changes Signed-off-by: ariamarble <armarble@amazon.com> * doc review changes Signed-off-by: ariamarble <armarble@amazon.com> * link to task api Signed-off-by: ariamarble <armarble@amazon.com> * further doc review updates Signed-off-by: ariamarble <armarble@amazon.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> * made editorial changes Signed-off-by: ariamarble <armarble@amazon.com> --------- Signed-off-by: ariamarble <armarble@amazon.com> Co-authored-by: Nathan Bower <nbower@amazon.com>
* Add documentation for wait_for_completion API Signed-off-by: ariamarble <armarble@amazon.com> * draft update Signed-off-by: ariamarble <armarble@amazon.com> * small comment Signed-off-by: ariamarble <armarble@amazon.com> * page and toc updates Signed-off-by: ariamarble <armarble@amazon.com> * page updates Signed-off-by: ariamarble <armarble@amazon.com> * final changes Signed-off-by: ariamarble <armarble@amazon.com> * doc review changes Signed-off-by: ariamarble <armarble@amazon.com> * link to task api Signed-off-by: ariamarble <armarble@amazon.com> * further doc review updates Signed-off-by: ariamarble <armarble@amazon.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> * made editorial changes Signed-off-by: ariamarble <armarble@amazon.com> --------- Signed-off-by: ariamarble <armarble@amazon.com> Co-authored-by: Nathan Bower <nbower@amazon.com>
* Add documentation for wait_for_completion API Signed-off-by: ariamarble <armarble@amazon.com> * draft update Signed-off-by: ariamarble <armarble@amazon.com> * small comment Signed-off-by: ariamarble <armarble@amazon.com> * page and toc updates Signed-off-by: ariamarble <armarble@amazon.com> * page updates Signed-off-by: ariamarble <armarble@amazon.com> * final changes Signed-off-by: ariamarble <armarble@amazon.com> * doc review changes Signed-off-by: ariamarble <armarble@amazon.com> * link to task api Signed-off-by: ariamarble <armarble@amazon.com> * further doc review updates Signed-off-by: ariamarble <armarble@amazon.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> * made editorial changes Signed-off-by: ariamarble <armarble@amazon.com> --------- Signed-off-by: ariamarble <armarble@amazon.com> Co-authored-by: Nathan Bower <nbower@amazon.com>
Description
Adds documentation for wait_for_completion API
Issues Resolved
fixes #3186
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.