Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for configurable merge policy #5137

Merged

Conversation

rishabhmaurya
Copy link
Contributor

Description

Configurable merge policy documentation

Issues Resolved

Closes #5119

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rishabhmaurya
Copy link
Contributor Author

rishabhmaurya commented Oct 3, 2023

@hdhalter @reta please review, thank you!
I'm planning to write a blog post with more details once opensearch-project/OpenSearch#9241 (comment) concerns are addressed and we set log_byte_size merge policy as default for time series indexes.

@Naarcha-AWS Naarcha-AWS self-assigned this Oct 3, 2023
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
@rishabhmaurya
Copy link
Contributor Author

@hdhalter @Naarcha-AWS can we get it merged if it looks good to you?

Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my changes (mostly to use active voice) to make sure I haven't changed the meaning. Thanks!

_api-reference/cluster-api/cluster-settings.md Outdated Show resolved Hide resolved
_im-plugin/index-settings.md Outdated Show resolved Hide resolved
rishabhmaurya and others added 2 commits October 4, 2023 15:28
Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
@rishabhmaurya
Copy link
Contributor Author

Looks good, thank you @hdhalter

@hdhalter hdhalter added v2.11.0 release-notes PR: Include this PR in the automated release notes labels Oct 4, 2023
@hdhalter
Copy link
Contributor

hdhalter commented Oct 4, 2023

I submitted it for editorial review, so we can merge it after it's been reviewed by Nathan.

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabhmaurya Please see my changes and let me know if you have any questions. Thanks!

_api-reference/cluster-api/cluster-settings.md Outdated Show resolved Hide resolved
_im-plugin/index-settings.md Outdated Show resolved Hide resolved
rishabhmaurya and others added 2 commits October 5, 2023 06:22
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
@rishabhmaurya
Copy link
Contributor Author

Looks good @natebower. Thank you.

@hdhalter hdhalter merged commit 7fd7cfa into opensearch-project:main Oct 5, 2023
3 checks passed
vagimeli pushed a commit that referenced this pull request Oct 13, 2023
* Documentation for configurable merge policy

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* substitute indices with indexes

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* substitute lucene with Lucene

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Update _im-plugin/index-settings.md

Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Update _api-reference/cluster-api/cluster-settings.md

Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Update _im-plugin/index-settings.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Update _api-reference/cluster-api/cluster-settings.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

---------

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
* Documentation for configurable merge policy

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* substitute indices with indexes

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* substitute lucene with Lucene

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Update _im-plugin/index-settings.md

Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Update _api-reference/cluster-api/cluster-settings.md

Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Update _im-plugin/index-settings.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Update _api-reference/cluster-api/cluster-settings.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

---------

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Co-authored-by: Nathan Bower <nbower@amazon.com>
vagimeli pushed a commit that referenced this pull request Dec 21, 2023
* Documentation for configurable merge policy

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* substitute indices with indexes

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* substitute lucene with Lucene

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Update _im-plugin/index-settings.md

Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Update _api-reference/cluster-api/cluster-settings.md

Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Update _im-plugin/index-settings.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Update _api-reference/cluster-api/cluster-settings.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

---------

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes PR: Include this PR in the automated release notes v2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Document behavior of new index.merge.policy setting
5 participants