-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for configurable merge policy #5137
Documentation for configurable merge policy #5137
Conversation
@hdhalter @reta please review, thank you! |
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
d56ba4b
to
e117301
Compare
@hdhalter @Naarcha-AWS can we get it merged if it looks good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review my changes (mostly to use active voice) to make sure I haven't changed the meaning. Thanks!
Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Looks good, thank you @hdhalter |
I submitted it for editorial review, so we can merge it after it's been reviewed by Nathan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishabhmaurya Please see my changes and let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Looks good @natebower. Thank you. |
* Documentation for configurable merge policy Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * substitute indices with indexes Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * substitute lucene with Lucene Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Update _im-plugin/index-settings.md Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Update _api-reference/cluster-api/cluster-settings.md Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Update _im-plugin/index-settings.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Update _api-reference/cluster-api/cluster-settings.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
* Documentation for configurable merge policy Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * substitute indices with indexes Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * substitute lucene with Lucene Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Update _im-plugin/index-settings.md Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Update _api-reference/cluster-api/cluster-settings.md Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Update _im-plugin/index-settings.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Update _api-reference/cluster-api/cluster-settings.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Nathan Bower <nbower@amazon.com>
* Documentation for configurable merge policy Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * substitute indices with indexes Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * substitute lucene with Lucene Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Update _im-plugin/index-settings.md Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Update _api-reference/cluster-api/cluster-settings.md Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Update _im-plugin/index-settings.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Update _api-reference/cluster-api/cluster-settings.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Nathan Bower <nbower@amazon.com>
Description
Configurable merge policy documentation
Issues Resolved
Closes #5119
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.