-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new use cases #588
Adding new use cases #588
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
============================================
+ Coverage 72.85% 72.95% +0.10%
Complexity 680 680
============================================
Files 81 81
Lines 3466 3479 +13
Branches 278 278
============================================
+ Hits 2525 2538 +13
Misses 822 822
Partials 119 119 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
c0efddb
to
a6fd478
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @amitgalitz! This feature would widen our plugin's use cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions
adding new use cases Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit eab5ab6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adding new use cases (#588) adding new use cases Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit eab5ab6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * removing _doc Signed-off-by: Amit Galitzky <amgalitz@amazon.com> --------- Signed-off-by: Amit Galitzky <amgalitz@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Amit Galitzky <amgalitz@amazon.com>
Description
This PR mainly adds a few new use cases, including there defaults and templates.
Additionally:
Some open questions:
I have quite a few templates that are very similar cause of slight changes in connectors, should I keep it that way for 2.13 or potentially have connectors get made with fields that are never used and that look like this:
"post_process_function": "${{create_connector.actions.post_process_function}}"
I was thinking it might confuse customers and not be the cleanest look.
For some of the more nested param I want users to have control over like the mapping and processors the keys were getting pretty nested so I tried to limit them but then it might not be as consistent. Let me know if you think this can be improved. Another potential solution is to just have the key be ${{node_id.last-field-name}} or two fields back incase they are the same like in hybrid-template.
for example now I have:
"${{normalization-processor.combination.technique}}"
and"${{normalization-processor.normalization.technique}}"
.this could be changed to
"${{create_search_pipeline.combination.technique}}"
and"${{create_search_pipeline.normalization.technique}}"
other fields like:
"text_embedding.field_map.input"
will change to"create_ingest_pipeline.field_map.input"
other option is keeping as is or having the full path in dot form
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.