[Backport 2.x] Nomenclature changes from Whitelist to Allowlist #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Signed-off-by: Naveen Tatikonda <navtat@amazon.com> Signed-off-by: Naveen Tatikonda <navtat@amazon.com> (cherry picked from commit c7379f8)
Codecov Report
@@ Coverage Diff @@
## 2.x #535 +/- ##
=========================================
Coverage 84.04% 84.04%
Complexity 1019 1019
=========================================
Files 146 146
Lines 4188 4188
Branches 373 373
=========================================
Hits 3520 3520
Misses 492 492
Partials 176 176
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
naveentatikonda
approved these changes
Sep 6, 2022
martin-gaievski
approved these changes
Sep 6, 2022
heemin32
approved these changes
Sep 6, 2022
heemin32
reviewed
Sep 6, 2022
|
|
||
| private static final Whitelist ALLOW_LIST = WhitelistLoader.loadFromResourceFiles(KNNWhitelistExtension.class, "knn_whitelist.txt"); | ||
| private static final Whitelist ALLOW_LIST = WhitelistLoader.loadFromResourceFiles(KNNAllowlistExtension.class, "knn_allowlist.txt"); | ||
|
|
||
| @Override | ||
| public Map<ScriptContext<?>, List<Whitelist>> getContextWhitelists() { |
There was a problem hiding this comment.
Do we have a plan to change this line as well?
There was a problem hiding this comment.
As mentioned in my actual PR. The nomenclature changes from whitelist to allowlist are not being supported by opensearch core in 2.x version and are only supported from version 3.0. We are using a couple of opensearch core whitelist packages. We will update these lines of code after we increment our version to 3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c7379f8 from #534