[Backport 1.x] Fix make_model_config_json function #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Improve make_model_config_json function Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Fix linting issues Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add unittest Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Fix bug Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Minor Edit + Add more tests Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Fix test Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct typos Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Increase test coverage Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Increase test coverage (2) Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Increase test coverage (3) Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Remove redundant line Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit 13149e8)
dhrubo-os
approved these changes
Jul 8, 2023
b4sjoo
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 13149e8 from #188