-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating notebook + bumping version #199
Conversation
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #199 +/- ##
=======================================
Coverage 91.15% 91.15%
=======================================
Files 37 37
Lines 4091 4091
=======================================
Hits 3729 3729
Misses 362 362
|
For the first plot, let's change the colors and update the figure shape:
|
For the second-to-last plot zooming in on the other suspected metrics in the first event, let's make it a little more clear where these metrics come from, keep their colors consistent with the first plot, and add event window highlighting:
|
Lastly, maybe add a short text block between the zoomed-in plot and the plot for the second event? Could be as simple as a line that says "Next we'll plot the second event." |
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-199-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1237aa61bb40cf6cef06002cffa02093ef4b2023
# Push it to GitHub
git push --set-upstream origin backport/backport-199-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
* updating notebook + bumping version Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressing comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit 1237aa6)
* updating notebook + bumping version Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressing comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit 1237aa6)
* updating notebook + bumping version Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressing comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit 1237aa6) Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> Co-authored-by: Dhrubo Saha <dhrubo@amazon.com>
* updating notebook + bumping version (#199) * updating notebook + bumping version Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressing comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit 1237aa6) * Add description field with make_model_config_json function (#203) * Add description field Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Restore notebook Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug test Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Resolve linting issues Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug test_sentencetransformermodel_pytest.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve test coverage Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Edit test name Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Change CHANGELOG.md & Add comment to sentencetransformermodel.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve add description Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Loosen restriction Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update sentencetransformermodel.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Change function name + Add comment + Add default description Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit 20435b1) --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> Co-authored-by: Dhrubo Saha <dhrubo@amazon.com>
* updating notebook + bumping version (#199) * updating notebook + bumping version Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressing comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit 1237aa6) * Add description field with make_model_config_json function (#203) * Add description field Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Restore notebook Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug test Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Resolve linting issues Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug test_sentencetransformermodel_pytest.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve test coverage Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Edit test name Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Change CHANGELOG.md & Add comment to sentencetransformermodel.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve add description Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Loosen restriction Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update sentencetransformermodel.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Change function name + Add comment + Add default description Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit 20435b1) * Backport Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Fix linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update test_sentencetransformermodel_pytest.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> Co-authored-by: Dhrubo Saha <dhrubo@amazon.com>
* updating notebook + bumping version (#199) * updating notebook + bumping version Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressing comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit 1237aa6) * Add description field with make_model_config_json function (#203) * Add description field Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Restore notebook Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug test Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Resolve linting issues Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug test_sentencetransformermodel_pytest.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve test coverage Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Edit test name Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Change CHANGELOG.md & Add comment to sentencetransformermodel.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Improve add description Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Loosen restriction Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Update sentencetransformermodel.py Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Change function name + Add comment + Add default description Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Debug Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit 20435b1) * Resolve merged conflict Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> Co-authored-by: Dhrubo Saha <dhrubo@amazon.com>
Description
[updating notebook + bumping version]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.