Update gemspec to include signing key path #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, signing key is expected to be at root of project with name gem-private_key.pem. Include only if command is gem and argument is gemspec and signing key exists. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
1 task
jayeshathila
reviewed
Dec 6, 2021
It is not empty, I changed the permission so that it is executable. This will be used by infra to build all gems |
Ah. As the git only tracks file's executable nature hence not showing any difference. Got it. |
jayeshathila
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com
Description
By default, signing key is expected to be at
root of project with name gem-private_key.pem.
Include only if command is gem and argument is gemspec and signing key exists.
Issues Resolved
#23
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.