[Backport 2.x] PRs for correlation engine and minor UX improvements #577
Commits on May 5, 2023
-
[BUG] Finding's fly-out has no correlations if open from alerts (open…
…search-project#558) * [BUG] Finding's fly-out has no correlations if open from alerts opensearch-project#557 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review from opensearch-project#558 (comment) Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
-
cypress | create detector specs update (opensearch-project#518)
* [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Provide empty states for Findings and Alerts page opensearch-project#471 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#493 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#493 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#493 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#493 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update detector details component opensearch-project#502 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update detector details component opensearch-project#502 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update detector details component opensearch-project#502 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update detector details component opensearch-project#502 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Feature] update detector details component opensearch-project#504 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Feature] update detector details component opensearch-project#504 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Update detector details component opensearch-project#504 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] No space between the detector details and the rule panel opensearch-project#522 [BUG] A rule flyout without references have an empty link opensearch-project#521 [FEATURE] Update header size to use euiTitle--small opensearch-project#520 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] No space between the detector details and the rule panel opensearch-project#522 [BUG] A rule flyout without references have an empty link opensearch-project#521 [FEATURE] Update header size to use euiTitle--small opensearch-project#520 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * refactored util methods into cypress commands Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * refactored util methods into cypress commands Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
-
added link to rules; simplified rule parsing (opensearch-project#571)
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
-
[FEATURE] Finding flyout loading state (opensearch-project#562)
* [FEATURE] Set loading state for finding fly-out until the data is ready opensearch-project#559 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
-
Add correlation rule details into the finding details flyout opensear…
…ch-project#563 (opensearch-project#565) * Add correlation rule details into the finding details flyout opensearch-project#563 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout opensearch-project#563 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
-
UX improvements for correlation engine (opensearch-project#561)
* passing props for date time filter (opensearch-project#551) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added loading state Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * ux improvements Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * transform vega-lite files for jest testing Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
-
Add a details button to open the findings flyout from the correlation…
…s page. (opensearch-project#572) * Add a details button to open the findings flyout from the correlations page. opensearch-project#564 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add a details button to open the findings flyout from the correlations page. opensearch-project#564 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Add a details button to open the findings flyout from the correlations page. opensearch-project#564 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
-
Wrong field mappings for the cloud trail logs (opensearch-project#574)
* Wrong field mappings for the cloud trail logs opensearch-project#573 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
-
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
-
updated osd branch for cypress tests
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.