Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update third party notice. #46

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

Description

In opensearch-project/sql#479 ODBC driver was updated to use libcurl as a http transport library. Unfortunately, we missed to update 3rd party notice file.
I added curl notice from https://github.com/curl/curl/blob/master/COPYING and removed PostgreS one, because there are no no postgres libs or dependencies. Perhaps it is a legacy part or copied by mistake from another driver.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@GumpacG
Copy link
Collaborator

GumpacG commented Jun 2, 2023

Does src/CMakeLists.txt need to have a license header as well as per https://docs.oracle.com/cd/E37069_01/html/E37094/glpkn.html?

@acarbonetto
Copy link
Collaborator

Does src/CMakeLists.txt need to have a license header as well as per https://docs.oracle.com/cd/E37069_01/html/E37094/glpkn.html?

I don't think that's the cmake file generated by autoconf, nor are they makefiles. I think we're ok just to put it into the THIRD-PARTY.

@MaxKsyunz MaxKsyunz merged commit a744dc3 into opensearch-project:main Jun 13, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the update-3rd-party-notice branch June 13, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants