Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Setting to Toggle Data Source Management Code Paths #2723

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Added Setting to Toggle Data Source Management Code Paths #2723

merged 1 commit into from
Jul 9, 2024

Conversation

fddattal
Copy link
Contributor

@fddattal fddattal commented Jun 6, 2024 •
edited
Loading

Description

This commit adds a setting that toggles data source management code paths.
It will disable explicit APIs and internal code paths that implicitly create data sources.

Issues Resolved

opensearch-project/OpenSearch#13274

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

@fddattal fddattal force-pushed the data_source_enabed_setting_refactor_main branch 18 times, most recently from 4220799 to 9b15c86 Compare June 7, 2024 20:52
@codecov Codecov
Copy link

codecov bot commented Jun 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.32%. Comparing base (7b40c2c) to head (a40081b).
Report is 5 commits behind head on main.

❗ Current head a40081b differs from pull request most recent head 8c57ec8

Please upload reports for the commit 8c57ec8 to get more accurate results.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2723      +/-   ##
============================================
+ Coverage     92.14%   92.32%   +0.17%     
- Complexity     4960     4989      +29     
============================================
  Files           496      497       +1     
  Lines         14341    14375      +34     
  Branches        942      946       +4     
============================================
+ Hits          13214    13271      +57     
+ Misses         1091     1067      -24     
- Partials         36       37       +1
Flag Coverage Δ
sql-engine 92.32% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fddattal fddattal force-pushed the data_source_enabed_setting_refactor_main branch 2 times, most recently from dd5ee20 to 1d05f83 Compare June 7, 2024 21:45
@fddattal fddattal marked this pull request as ready for review June 7, 2024 22:31
@fddattal fddattal force-pushed the data_source_enabed_setting_refactor_main branch from a827d03 to 454e2d7 Compare June 12, 2024 18:48
@fddattal fddattal force-pushed the data_source_enabed_setting_refactor_main branch 7 times, most recently from dc321b2 to a40081b Compare June 17, 2024 23:07
@fddattal fddattal force-pushed the data_source_enabed_setting_refactor_main branch 2 times, most recently from 9f60aff to 8c57ec8 Compare June 25, 2024 19:10
penghuo
penghuo previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

rupal-bq
rupal-bq previously approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@rupal-bq rupal-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@fddattal fddattal force-pushed the data_source_enabed_setting_refactor_main branch from 8c57ec8 to 1f039ea Compare July 9, 2024 05:28
@fddattal
Added Setting to Toggle Data Source Management Code Paths
c8fdabf 
Signed-off-by: Frank Dattalo <fddattal@amazon.com>
@fddattal fddattal dismissed stale reviews from rupal-bq and penghuo via c8fdabf July 9, 2024 06:04
@fddattal fddattal force-pushed the data_source_enabed_setting_refactor_main branch from 1f039ea to c8fdabf Compare July 9, 2024 06:04
penghuo
penghuo approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@penghuo penghuo merged commit d639796 into opensearch-project:main Jul 9, 2024
11 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 9, 2024
@github-actions
Added Setting to Toggle Data Source Management Code Paths (#2723)
28eed63 
Signed-off-by: Frank Dattalo <fddattal@amazon.com>
(cherry picked from commit d639796)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 9, 2024
Merged
penghuo added a commit that referenced this pull request Jul 10, 2024
@opensearch-trigger-bot @github-actions @penghuo
Added Setting to Toggle Data Source Management Code Paths (#2723) (#2811
9c3fc29 
)

(cherry picked from commit d639796)

Signed-off-by: Frank Dattalo <fddattal@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Peng Huo <penghuo@gmail.com>
@rupal-bq rupal-bq added needs-documentation v2.16.0 Issues targeting release v2.16.0 labels Jul 19, 2024
manasvinibs pushed a commit to manasvinibs/sql that referenced this pull request Aug 14, 2024
@fddattal @manasvinibs
Added Setting to Toggle Data Source Management Code Paths (opensearch…
2fc4536 
…-project#2723)

Signed-off-by: Frank Dattalo <fddattal@amazon.com>
jzonthemtn pushed a commit to jzonthemtn/sql that referenced this pull request Aug 28, 2024
@fddattal @jzonthemtn
Added Setting to Toggle Data Source Management Code Paths (opensearch…
4f1f051 
…-project#2723)

Signed-off-by: Frank Dattalo <fddattal@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rupal-bq rupal-bq rupal-bq approved these changes

@penghuo penghuo penghuo approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon vamsi-amazon is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

Assignees
No one assigned
Labels
backport 2.x needs-documentation v2.16.0 Issues targeting release v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fddattal @penghuo @rupal-bq