Exclude integ-test and download task when built offline #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykmr1224
added
backport 2.x
maintenance
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
seankao-az
approved these changes
Jun 18, 2024
rupal-bq
approved these changes
Jun 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
Signed-off-by: Tomoyuki Morita <moritato@amazon.com> (cherry picked from commit 07e52d9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jzonthemtn
pushed a commit
to jzonthemtn/sql
that referenced
this pull request
Aug 28, 2024
…nsearch-project#2760) Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
async-query-coremodule buildable in offline environment (it still requires Gradle cache)--offlineoption,integ-testanddoctestwill be excluded, and also download of .g4 files are skipped. Even if we specify target such as:async-query-core:shadowJar, some downloads were done during preparation, and build failed even thoughasync-query-coremodule does not depend oninteg-test.Issues Resolved
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.