Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremented version to 1.3.2. #593

Merged
merged 2 commits into from
May 2, 2022

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Apr 28, 2022

Signed-off-by: Zelin Hao zelinhao@amazon.com

Description

Incremented version to 1.3.2.

Issues Resolved

Part of opensearch-project/opensearch-build#1882

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh requested a review from a team as a code owner April 28, 2022 19:30
@joshuali925
Copy link
Member

ml artifact (https://github.com/zelinh/sql/blob/increment-to-1.3.2/doctest/resources/ml-commons/opensearch-ml-1.3.1.0-SNAPSHOT.zip) should be 1.3.2? also this seems to be a duplicate of #526

@zelinh
Copy link
Member Author

zelinh commented Apr 28, 2022

We just added ml-commons to our CI manifest. Should be getting the snapshot artifacts after build.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh
Copy link
Member Author

zelinh commented May 2, 2022

@joshuali925
It seems like the CI tests fetch the ml artifacts from the old URL https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.2/latest/linux/x64/builds/opensearch/plugins/opensearch-ml-1.3.2.0.zip
and missed the additional tar folder.
The new CI link should be https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.2/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-ml-1.3.2.0.zip

Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925
Copy link
Member

updated your branch @zelinh

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #593 (48a2bdb) into 1.3 (c0c8ed8) will increase coverage by 3.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #593      +/-   ##
============================================
+ Coverage     95.25%   98.40%   +3.14%     
  Complexity     2746     2746              
============================================
  Files           276      266      -10     
  Lines          7416     6758     -658     
  Branches        545      427     -118     
============================================
- Hits           7064     6650     -414     
+ Misses          298      107     -191     
+ Partials         54        1      -53     
Flag Coverage Δ
query-workbench ?
sql-engine 98.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
workbench/public/application.tsx
workbench/public/components/Main/main.tsx
workbench/public/utils/PanelWrapper.tsx
workbench/public/components/PPLPage/PPLPage.tsx
...h/public/components/QueryLanguageSwitch/Switch.tsx
workbench/public/components/app.tsx
workbench/public/components/Header/Header.tsx
...ublic/components/QueryResults/QueryResultsBody.tsx
...ch/public/components/QueryResults/QueryResults.tsx
workbench/public/components/SQLPage/SQLPage.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c8ed8...48a2bdb. Read the comment docs.

@zelinh
Copy link
Member Author

zelinh commented May 2, 2022

@joshuali925 Could you help rerun the failed test? Seems like a connection error.

Run actions/setup-node@v1
Unexpected HTTP response: 500
Waiting [10](https://github.com/opensearch-project/sql/runs/6263744512?check_suite_focus=true#step:4:10) seconds before trying again
Unexpected HTTP response: 500
Waiting 15 seconds before trying again
Error: Unexpected HTTP response: 500

@joshuali925 joshuali925 merged commit 04dcd27 into opensearch-project:1.3 May 2, 2022
@penghuo penghuo mentioned this pull request May 19, 2022
6 tasks
ps48 added a commit that referenced this pull request Jul 28, 2022
* Disable flaky test in JdbcTestIT. (#475)

Signed-off-by: penghuo <penghuo@gmail.com>

* Update dependency opensearch-ml-client group name (#477)

Signed-off-by: jackieyanghan <jkhanjob@gmail.com>

* Collected fixes related to bugs #280, #302, #783, #696 and 317 all together. (#479)

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>

* Add JDK 8 to CI Matrix  (#483) (#484)

* fixed references in java 8 and added to ci matrix
* filter test that fails due to jdk 8 bug
* use different degree to radian conversion for difference in jdk
* skip date time format tests that cause error due to jdk bug
* only disable DateTime unit test on Java 8

Bypassing failed DCO check

Signed-off-by: David Cui <davidcui@amazon.com>
(cherry picked from commit b6fccbd)

Co-authored-by: David Cui <53581635+davidcui1225@users.noreply.github.com>

* Add parse docs to PPL commands index (#486) (#487)

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add 1.3.0 release notes (#492)

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Add Kmeans and AD command documentation (#493) (#497)

Signed-off-by: jackieyanghan <jkhanjob@gmail.com>
(cherry picked from commit ee4bce0)

* Bump version to 1.3.1

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Bump ml

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Add new zip

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Updated release drafter

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Remove checked-in ml-commons dependency (#529)

Signed-off-by: jackieyanghan <jkhanjob@gmail.com>

* Bump workbench to 1.3.1 (#540)

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Bug Fix, return default ID when log4j ThreadContext is empty (#538) (#539) (#543)

Signed-off-by: penghuo <penghuo@gmail.com>
(cherry picked from commit 54b7257)

* Incremented version to 1.3.2. (#593)

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>

Co-authored-by: Joshua Li <joshuali925@gmail.com>

* Version bump 1.3.3

Signed-off-by: pgodithi <pgodithi@amazon.com>

* [1.3] Bump spring-beans to 5.2.20 (#632)

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Version bump 1.3.3

Signed-off-by: pgodithi <pgodithi@amazon.com>

* Incremented version to 1.3.4. (#681)

* Incremented version to 1.3.4.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

* bump jackson to 2.13.2

Signed-off-by: Joshua Li <joshuali925@gmail.com>

Co-authored-by: Joshua Li <joshuali925@gmail.com>

Co-authored-by: Peng Huo <penghuo@gmail.com>
Co-authored-by: Jackie Han <41348518+jackiehanyang@users.noreply.github.com>
Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: David Cui <53581635+davidcui1225@users.noreply.github.com>
Co-authored-by: Eugene Lee <eugenesk@amazon.com>
Co-authored-by: Sayali Gaikawad <gaiksaya@amazon.com>
Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com>
Co-authored-by: pgodithi <pgodithi@amazon.com>
Co-authored-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants