Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for notification channels #68

Conversation

alexconlin
Copy link
Contributor

Signed-off-by: Alex Conlin-Oakley 458604+alexconlin@users.noreply.github.com

Description

Adds support for configuring channels in the OpenSearch notifications plugin.

Issues Resolved

Closes #30

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi
Copy link
Member

Thanks for the contribution @alexconlin, I will take a look at this PR and provide feedback shortly.
Adding @bbarani @phillbaker @peterzhuamazon

@prudhvigodithi
Copy link
Member

The test initially failed with error

  Running [/home/runner/golangci-lint-1.29.0-linux-amd64/golangci-lint run --out-format=github-actions --verbose --timeout=10m] in [] ...
  Error: File is not `gofmt`-ed with `-s` (gofmt)
  Error: File is not `gofmt`-ed with `-s` (gofmt)

@alexconlin can you run golangci-lint run --out-format=github-actions on your local to replicate the error?
Thank you

Signed-off-by: Alex Conlin-Oakley <458604+alexconlin@users.noreply.github.com>
@alexconlin alexconlin force-pushed the support-notification-channels branch from 5ef5c25 to f9dcfeb Compare August 15, 2023 16:15
@alexconlin
Copy link
Contributor Author

@prudhvigodithi those errors should be fixed now. Please could you re-approve the test run?

@prudhvigodithi
Copy link
Member

Thanks @alexconlin can you also run the https://github.com/hashicorp/terraform-plugin-docs, this should generate the resources and examples for this new notification support.

@prudhvigodithi
Copy link
Member

LGTM, @alexconlin can you please generate the tfdocs?
@phillbaker please take a look when you get a chance. Thank you

Signed-off-by: Alex Conlin-Oakley <458604+alexconlin@users.noreply.github.com>
@alexconlin
Copy link
Contributor Author

@prudhvigodithi I have updated the documentation with tfplugindocs.

I notice that the url parameter has moved from Required to Optional. It does that when I generate docs on the main branch as well. It seems to be related to this issue in terraform-plugin-docs.

@shurkus
Copy link

shurkus commented Aug 31, 2023

Any news?

@bbarani
Copy link
Member

bbarani commented Aug 31, 2023

@phillbaker can you please take a look when you get a chance?

@prudhvigodithi prudhvigodithi merged commit ebbbc8c into opensearch-project:main Sep 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support notifications
4 participants