-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for notification channels #68
add support for notification channels #68
Conversation
Thanks for the contribution @alexconlin, I will take a look at this PR and provide feedback shortly. |
The test initially failed with error
@alexconlin can you run |
Signed-off-by: Alex Conlin-Oakley <458604+alexconlin@users.noreply.github.com>
5ef5c25
to
f9dcfeb
Compare
@prudhvigodithi those errors should be fixed now. Please could you re-approve the test run? |
Thanks @alexconlin can you also run the https://github.com/hashicorp/terraform-plugin-docs, this should generate the resources and examples for this new notification support. |
LGTM, @alexconlin can you please generate the tfdocs? |
Signed-off-by: Alex Conlin-Oakley <458604+alexconlin@users.noreply.github.com>
@prudhvigodithi I have updated the documentation with tfplugindocs. I notice that the |
Any news? |
@phillbaker can you please take a look when you get a chance? |
Signed-off-by: Alex Conlin-Oakley 458604+alexconlin@users.noreply.github.com
Description
Adds support for configuring channels in the OpenSearch notifications plugin.
Issues Resolved
Closes #30
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.