Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

tests/e2e: move tcp test to own file and test permissive mode #2227

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

shashankram
Copy link
Member

Description:
Moves the TCP traffic test to its own file and adds a scenario
to test traffic in permissive mode.

Part of #1521

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [X]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    No

Moves the TCP traffic test to its own file and adds a scenario
to test traffic in permissive mode.

Part of openservicemesh#1521

Signed-off-by: Shashank Ram <shashr2204@gmail.com>
@shashankram shashankram requested a review from a team as a code owner December 21, 2020 18:08
@codecov-io
Copy link

Codecov Report

Merging #2227 (e75b6d0) into main (4defb02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2227   +/-   ##
=======================================
  Coverage   57.73%   57.73%           
=======================================
  Files         145      145           
  Lines        6299     6299           
=======================================
  Hits         3637     3637           
  Misses       2658     2658           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4defb02...e75b6d0. Read the comment docs.

@ksubrmnn
Copy link
Contributor

Is there a reason that the client pod is not behind a service?

@shashankram
Copy link
Member Author

Is there a reason that the client pod is not behind a service?

Yes, because client pods in kubernetes don't have to be backed by services. We had the limitation to create services for clients which has been removed, so it makes sense to test it the way real users would wire up their apps, which is without needing to create a service for client pods.

There are a few other tests that create services for client, but it didn't make sense to replicate this for all tests since we aren't testing anything additional.

@shashankram shashankram merged commit 932c691 into openservicemesh:main Dec 21, 2020
@shashankram shashankram deleted the tcp-perm-e2e branch December 21, 2020 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants