This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
[HOLD] chore: convert ServiceIdentity to struct #3732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3732 +/- ##
==========================================
+ Coverage 67.65% 69.87% +2.21%
==========================================
Files 181 185 +4
Lines 8772 8986 +214
==========================================
+ Hits 5935 6279 +344
+ Misses 2804 2658 -146
- Partials 33 49 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
allenlsy
force-pushed
the
serviceidentity-struct
branch
from
b6530ef
to
d8c5ae4
Compare
Signed-off-by: Allen Leigh <allenlsy@gmail.com>
allenlsy
force-pushed
the
serviceidentity-struct
branch
from
d8c5ae4
to
5c6126a
Compare
shashankram
reviewed
Jul 7, 2021
| type ServiceIdentity struct { | ||
| ServiceAccount string | ||
| Namespace string | ||
| ClusterDomain string |
There was a problem hiding this comment.
In the future, we will need to support non k8s env such as VMs. We most likely will continue to use a ServiceAccount to map non k8s identity types (such as service principals).
Suggested change
| ClusterDomain string | |
| TrustDomain string |
shashankram
reviewed
Jul 7, 2021
Comment on lines
+42
to
+48
| serviceIdentity := lb.serviceIdentity | ||
| proxyIdentity := identity.ServiceIdentity{ | ||
| ServiceAccount: serviceIdentity.ServiceAccount, | ||
| Namespace: serviceIdentity.Namespace, | ||
| ClusterDomain: serviceIdentity.ClusterDomain, | ||
| } | ||
| trafficTargets, err := lb.meshCatalog.ListInboundTrafficTargetsWithRoutes(serviceIdentity) |
There was a problem hiding this comment.
Suggested change
| serviceIdentity := lb.serviceIdentity | |
| proxyIdentity := identity.ServiceIdentity{ | |
| ServiceAccount: serviceIdentity.ServiceAccount, | |
| Namespace: serviceIdentity.Namespace, | |
| ClusterDomain: serviceIdentity.ClusterDomain, | |
| } | |
| trafficTargets, err := lb.meshCatalog.ListInboundTrafficTargetsWithRoutes(serviceIdentity) | |
| trafficTargets, err := lb.meshCatalog.ListInboundTrafficTargetsWithRoutes(lb.serviceIdentity) |
| Namespace: serviceIdentity.Namespace, | ||
| ClusterDomain: serviceIdentity.ClusterDomain, | ||
| } | ||
| trafficTargets, err := lb.meshCatalog.ListInboundTrafficTargetsWithRoutes(serviceIdentity) | ||
| if err != nil { | ||
| log.Error().Err(err).Msgf("Error listing allowed inbound traffic targets for proxy identity %s", proxyIdentity) |
There was a problem hiding this comment.
s/proxyIdentity/lb.serviceIdentity
allenlsy
added
the
do-not-merge/hold
allenlsy
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Leigh allenlsy@gmail.com
Description:
Use struct to define ServiceIdentity, to provide more context.
Issue #3188
Affected area:
Please answer the following questions with yes/no.
No
No