Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15734: Remove helper from Oracle platform when hover on it #2352

Merged

Conversation

jgyselov
Copy link
Collaborator

@jgyselov jgyselov added the OCM label Sep 12, 2023
@jgyselov jgyselov requested a review from a team as a code owner September 12, 2023 08:19
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 12, 2023

@jgyselov: This pull request references MGMT-15734 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/MGMT-15734

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2023

New changes are detected. LGTM label has been removed.

@jgyselov jgyselov added this to the v2.26 milestone Sep 12, 2023
@ammont82 ammont82 merged commit e5d1d61 into openshift-assisted:master Sep 12, 2023
7 checks passed
rawagner pushed a commit to rawagner/facet-lib that referenced this pull request Sep 13, 2023
Co-authored-by: Jonathan Kilzi <jkilzi@redhat.com>
rawagner pushed a commit to rawagner/facet-lib that referenced this pull request Sep 13, 2023
Co-authored-by: Jonathan Kilzi <jkilzi@redhat.com>
rawagner pushed a commit that referenced this pull request Sep 13, 2023
Co-authored-by: Jonathan Kilzi <jkilzi@redhat.com>
jgyselov added a commit to jgyselov/assisted-installer-ui that referenced this pull request Sep 14, 2023
Co-authored-by: Jonathan Kilzi <jkilzi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. OCM size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants