update peer dependencies #2448
Merged
update peer dependencies #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/S
ammont82
approved these changes
Dec 7, 2023
rawagner
approved these changes
Dec 11, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ammont82, jschuler, rawagner The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jschuler we approve the PR. |
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OCM codebase:
Before
➜ uhc-portal git:(pf-v5-upgrade) ✗ npx check-peer-dependencies
❌ @openshift-console/dynamic-plugin-sdk 0.0.3 is required by @openshift-assisted/ui-lib@1.0.0) (0.0.19 is installed)
❌ react-dom ^17 is required by @openshift-assisted/ui-lib@1.0.0) (18.2.0 is installed)
✅ react-redux ^8.0.5 is required by @openshift-assisted/ui-lib@1.0.0 (8.1.1 is installed)
❌ react ^17 is required by @openshift-assisted/ui-lib@1.0.0) (18.2.0 is installed)
After
➜ uhc-portal git:(pf-v5-upgrade) ✗ npx check-peer-dependencies
✅ react-dom ^17 || ^18 is required by @openshift-assisted/ui-lib@1.0.0 (18.2.0 is installed)
✅ react-redux ^8.0.5 is required by @openshift-assisted/ui-lib@1.0.0 (8.1.1 is installed)
✅ react ^17 || ^18 is required by @openshift-assisted/ui-lib@1.0.0 (18.2.0 is installed)
Also
@openshift-console/dynamic-plugin-sdkuses PF4, it's better as a dependency not peer-dep, since OCM is upgrading to PF5 (this lib is not used by OCM).