Forward all sync parameters to the remote host #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
force-pushed
the
skuznets/forward-sync-params
branch
from
90f0dd4
to
7ebc26e
Compare
|
LGTM Fixes #315 |
0xmichalis
reviewed
Jul 11, 2017
| we take structured data from the configuration and | ||
| immediately flatten it into XML strings in these | ||
| generators. A proper approach would keep the data | ||
| structured and, perhaps, do the conversion to XML |
There was a problem hiding this comment.
Yeah, for now it's fine - can we get a card where we'll investigate this?
There was a problem hiding this comment.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/forward-sync-params
branch
from
7ebc26e
to
d00cb47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/cc @Kargakis
This should fix whatever issue we had about forwarding stuff and will make it easier to write the
started.jsongenerator for GCS