OCPCLOUD-2464,OCPCLOUD-2461,ART-8869: RPM Add ose-azure-acr-image-credential-provider #4405
Conversation
| git: | ||
| branch: | ||
| target: release-{MAJOR}.{MINOR} | ||
| url: git@github.com:openshift-priv/cloud-provider-azure.git |
There was a problem hiding this comment.
For aws we started using the openshift org, not openshift-priv. Is there a step needed to move to priv?
There was a problem hiding this comment.
openshift-priv/cloud-provider-azure exists
There was a problem hiding this comment.
no additional configuration required.
theobarberbany
changed the title
theobarberbany
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@theobarberbany: This pull request references OCPCLOUD-2461 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
theobarberbany
force-pushed
the
acr-credential-provider-4.16
branch
from
979b663
to
a77d08d
Compare
ashwindasr
changed the title
|
@theobarberbany: This pull request references ART-8869 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
theobarberbany
changed the title
|
@theobarberbany: This pull request references OCPCLOUD-2464 which is a valid jira issue. This pull request references OCPCLOUD-2461 which is a valid jira issue. This pull request references ART-8869 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Throwing on a /hold in case we need rhel8 as well. I don't think this should block us on getting rhel9 builds working though! :) |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
theobarberbany
force-pushed
the
acr-credential-provider-4.16
branch
2 times, most recently
from
eeaa38d
to
cb1bf69
Compare
Adds build config for azure-acr-image-credential-provider and gcp-gcr-image-credential-provider
theobarberbany
force-pushed
the
acr-credential-provider-4.16
branch
from
cb1bf69
to
37f8164
Compare
|
I think these builds are good to go! @ashwindasr is there anything else that needs doing for the el8 bilds - or is uncommenting the lines good enough? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashwindasr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged commit 6f4f60b
into
openshift-eng:openshift-4.16
Adds build config for azure-acr-image-credential-provider