Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.14] Add post install logic for namespaced brokers (#3889) #1094

Conversation

pierDipi
Copy link
Member

@openshift-ci openshift-ci bot requested review from aliok and lberk May 15, 2024 16:04
@pierDipi pierDipi requested review from creydr and Cali0707 May 15, 2024 16:04
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold for uptream

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the cp-b41ae240a8d499560c7a58192549703bffef5e2e-v1.14 branch from ba18345 to 2a6d9d7 Compare May 16, 2024 07:26
@openshift-ci openshift-ci bot removed the lgtm label May 16, 2024
@pierDipi pierDipi requested a review from Cali0707 May 16, 2024 07:27
@pierDipi
Copy link
Member Author

/retest-required

@pierDipi
Copy link
Member Author

/unhold

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 31, 2024
Copy link

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit beba7b0 into openshift-knative:release-v1.14 May 31, 2024
7 checks passed
@pierDipi pierDipi deleted the cp-b41ae240a8d499560c7a58192549703bffef5e2e-v1.14 branch May 31, 2024 13:49
@pierDipi pierDipi restored the cp-b41ae240a8d499560c7a58192549703bffef5e2e-v1.14 branch August 5, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants