Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new midstream branches #162

Closed
wants to merge 1 commit into from
Closed

Add new midstream branches #162

wants to merge 1 commit into from

Conversation

serverless-qe
Copy link
Collaborator

Discover new branches using openshift-knative/hack.

@openshift-ci openshift-ci bot requested review from mgencur and skonto June 18, 2024 05:28
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: serverless-qe
Once this PR has been reviewed and has the lgtm label, please assign matzew for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mgencur
mgencur reviewed Jun 18, 2024
View reviewed changes
config/backstage-plugins.yaml
@@ -1,6 +1,9 @@
config:
branches:
release-v1.12:
konflux:
Copy link
Contributor

@mgencur mgencur Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might have been better to define json:"enabled,omitempty" yaml:"enabled,omitempty" here https://github.com/openshift-knative/hack/pull/161/files#diff-9cb0409bd8a2445656e16ee55c0cc76205f9e9753d4cafa7d59d9bd879395ffdR78 , so that these elements can be ommitted?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierDipi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let me fix that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#164

@pierDipi pierDipi closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi left review comments

@mgencur mgencur mgencur left review comments

@skonto skonto Awaiting requested review from skonto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serverless-qe @mgencur @pierDipi