Add links for arm64 artifacts to consoleclidownload.go

[mvinkler]

Fixes JIRA SRVCOM-3099

Proposed Changes

🐛 fix - add missing links for arm64 kn to OCP Command Line Tools page

[Kaustubh-pande]

@mvinkler we need to update the expected number-

serverless-operator/test/servinge2e/verify_deploy_resources_test.go

Line 26 in 7d60f86

if len(ccd.Spec.Links) != 5 {

[pierDipi]

	0s
{Failed  === RUN   TestKnConsoleCLIDownload
    verify_deploy_resources_test.go:46: Failed to verify kn CCD, kn artifact "https://kn-openshift-serverless.apps.serverless-ocp-4-15-amd64-aws-us-east-1-mms7d.serverless.devcluster.openshift.com/kn-linux-arm64.tar.gz" size 19 less than 10MB
    verify_deploy_resources_test.go:46: Failed to verify kn CCD, kn artifact "https://kn-openshift-serverless.apps.serverless-ocp-4-15-amd64-aws-us-east-1-mms7d.serverless.devcluster.openshift.com/kn-darwin-arm64.tar.gz" size 19 less than 10MB
--- FAIL: TestKnConsoleCLIDownload (0.12s)
}

[pierDipi]

/cherry-pick release-1.33

[openshift-cherrypick-robot]

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mvinkler]

@dsimansk any idea why the Content-Length header returns 19 bytes for both arm downloads?

 === RUN   TestKnConsoleCLIDownload
    verify_deploy_resources_test.go:46: Failed to verify kn CCD, kn artifact "https://kn-openshift-serverless.apps.serverless-ocp-4-15-amd64-aws-us-east-1-mms7d.serverless.devcluster.openshift.com/kn-linux-arm64.tar.gz" size 19 less than 10MB
    verify_deploy_resources_test.go:46: Failed to verify kn CCD, kn artifact "https://kn-openshift-serverless.apps.serverless-ocp-4-15-amd64-aws-us-east-1-mms7d.serverless.devcluster.openshift.com/kn-darwin-arm64.tar.gz" size 19 less than 10MB 

[dsimansk]

@dsimansk any idea why the Content-Length header returns 19 bytes for both arm downloads?

 === RUN   TestKnConsoleCLIDownload
    verify_deploy_resources_test.go:46: Failed to verify kn CCD, kn artifact "https://kn-openshift-serverless.apps.serverless-ocp-4-15-amd64-aws-us-east-1-mms7d.serverless.devcluster.openshift.com/kn-linux-arm64.tar.gz" size 19 less than 10MB
    verify_deploy_resources_test.go:46: Failed to verify kn CCD, kn artifact "https://kn-openshift-serverless.apps.serverless-ocp-4-15-amd64-aws-us-east-1-mms7d.serverless.devcluster.openshift.com/kn-darwin-arm64.tar.gz" size 19 less than 10MB 

Well, midstream image doesn't have those archives enabled, or they are named differently.

We only have the following archives at the moment:
https://github.com/openshift-knative/client/blob/main/openshift/ci-operator/knative-images/client/Dockerfile.cliartifacts

[dsimansk]

@mvinkler it should pass even the download test with changes made in midstream kn-cli-artifacts.

openshift-knative/client#378

[dsimansk]

In addition we synced with @Kaustubh-pande on the naming scheme. In the cli image we will keep archive names with kn-macos-* to keep it consistent.

[dsimansk]

Current structure in midstream image:

[root@c30a67b9bb13 kn]# ls -lR
.:
total 12
-rw-rw-r--. 1 root root 11357 May 13 19:22 LICENSE
drwxr-xr-x. 2 root root    35 May 13 19:39 linux_amd64
drwxr-xr-x. 2 root root    35 May 13 19:39 linux_arm64
drwxr-xr-x. 2 root root    37 May 13 19:39 linux_ppc64le
drwxr-xr-x. 2 root root    35 May 13 19:39 linux_s390x
drwxr-xr-x. 2 root root    35 May 13 19:39 macos_amd64
drwxr-xr-x. 2 root root    35 May 13 19:39 macos_arm64
drwxr-xr-x. 2 root root    34 May 13 19:39 windows

./linux_amd64:
total 47696
-rw-r--r--. 1 root root 48837246 May 13 19:38 kn-linux-amd64.tar.gz

./linux_arm64:
total 44480
-rw-r--r--. 1 root root 45546738 May 13 19:38 kn-linux-arm64.tar.gz

./linux_ppc64le:
total 44412
-rw-r--r--. 1 root root 45475797 May 13 19:38 kn-linux-ppc64le.tar.gz

./linux_s390x:
total 47040
-rw-r--r--. 1 root root 48165706 May 13 19:38 kn-linux-s390x.tar.gz

./macos_amd64:
total 47408
-rw-r--r--. 1 root root 48542499 May 13 19:38 kn-macos-amd64.tar.gz

./macos_arm64:
total 8
-rw-r--r--. 1 root root 4134 May 13 19:38 kn-macos-arm64.tar.gz

./windows:
total 48084
-rw-r--r--. 1 root root 49236005 May 13 19:39 kn-windows-amd64.zip

[dsimansk]

/approve
/lgtm

For tests
/hold
/cherry-pick release-1.33

[openshift-cherrypick-robot]

@dsimansk: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

In response to this:

/approve
/lgtm

For tests
/hold
/cherry-pick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dsimansk]

/retest

[dsimansk]

/lgtm
/unhold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, mvinkler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dsimansk]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9bbfebb and 2 for PR HEAD 2c80806 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 30d73a4 and 1 for PR HEAD 2c80806 in total

[dsimansk]

Pendig update on CI config side first: openshift/release#51996

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2781e56 and 0 for PR HEAD 2c80806 in total

[dsimansk]

/hold

[openshift-ci]

@mvinkler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/415-upstream-e2e-kafka-aws-415	2c80806	link	false	/test 415-upstream-e2e-kafka-aws-415

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dsimansk]

/test 415-operator-e2e-aws-415

[dsimansk]

/unhold

[mvinkler]

/retest-required

[openshift-cherrypick-robot]

@pierDipi: new pull request created: #2662

In response to this:

/cherry-pick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.