[RELEASE-1.14] Incorporate upstream encryption changes to Serving #702
Conversation
|
/test 415-test-e2e-tls-aws-415 |
/test 415-test-e2e-tls-aws-415 |
/test 415-test-e2e-tls-aws-415 |
| export CA_CERT=ca-cert | ||
| # This needs to match $san from test/config/tls/generate.sh | ||
| export SERVER_NAME=knative.dev | ||
| fi | ||
| } | ||
|
|
||
| function run_e2e_tests(){ |
There was a problem hiding this comment.
Curious if you want to enable tests from ./test/e2e/systeminternaltls or what's the plan for those tests? I want to add the test for certificate rotation there.
There was a problem hiding this comment.
Good idea, I'll take a look.
There was a problem hiding this comment.
Let's see if that works out. We'll need patches for the tests, as OCP is a bit different. But we need to wait for knative#15217, otherwise we'll have to do it twice.
ReToCode
changed the title
|
/test 415-test-e2e-tls-aws-415 |
1 similar comment
|
/test 415-test-e2e-tls-aws-415 |
|
Not sure if we really have test failures, IMHO we just time out:
|
|
/unhold |
ReToCode
changed the title
|
/hold we need #732 first (as it changes the patch). |
|
LGTM |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-bot
bot
merged commit ff14af6
into
openshift-knative:release-v1.14
Fixes JIRA https://issues.redhat.com/browse/SRVKS-1198
Changes
ENABLE_INTERNAL_TLS->ENABLE_TLScluster-local-domain-tlsandsystem-internal-tlsclusterlocaldomaintlsandsysteminternaltlsPatches will be ported to main on a separate PR.