Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.14] Sync upstream release #737

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

github-actions[bot]
Copy link

Sync upstream release

knative-prow-robot and others added 5 commits May 23, 2024 20:09
…abled (knative#15243)

Co-authored-by: dprotaso <dprotaso@gmail.com>
Co-authored-by: Izabela Gomes <igomes@vmware.com>
…sn't happen which causesexpired lease to get stuck. (knative#15257)

Co-authored-by: Mukul Garg <37508311+mukulgit123@users.noreply.github.com>
Copy link

openshift-ci bot commented May 31, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a openshift-knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

no changes - just for easier comparing with upstream

@ReToCode
Copy link
Member

/ok-to-test

@ReToCode
Copy link
Member

ReToCode commented Jun 3, 2024

/approve

Copy link

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: github-actions[bot], ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a84008c into release-v1.14 Jun 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants