Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to networks-status #1420

Merged

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Mar 6, 2023

Annotation k8s.v1.cni.cncf.io/networks-status has been changed to k8s.v1.cni.cncf.io/network-status and the former is no longer supported. Use the new key in e2e tests utilities.

Refs:
k8snetworkplumbingwg/network-attachment-definition-client/pull/45

Annotation `k8s.v1.cni.cncf.io/networks-status` has been changed
to `k8s.v1.cni.cncf.io/network-status` and the former is no longer
supported. Use the new key in e2e tests utilities.

Refs:
k8snetworkplumbingwg/network-attachment-definition-client/pull/45

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
@zeeke zeeke force-pushed the annotation-network-status branch from 52ac10a to 21395f2 Compare March 6, 2023 12:37
@cgoncalves
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023
@SchSeba
Copy link
Member

SchSeba commented Mar 9, 2023

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@zeeke
Copy link
Member Author

zeeke commented Mar 9, 2023

/retest

2 similar comments
@zeeke
Copy link
Member Author

zeeke commented Mar 22, 2023

/retest

@zeeke
Copy link
Member Author

zeeke commented Mar 23, 2023

/retest

@zeeke
Copy link
Member Author

zeeke commented Mar 23, 2023

/override ci/prow/e2e-gcp-ovn

as per this thread

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2023

@zeeke: zeeke unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/override ci/prow/e2e-gcp-ovn

as per this thread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SchSeba
Copy link
Member

SchSeba commented Mar 23, 2023

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2023

@SchSeba: Overrode contexts on behalf of SchSeba: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 026c9b8 into openshift-kni:master Mar 23, 2023
@SchSeba
Copy link
Member

SchSeba commented Mar 27, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot

@SchSeba: new pull request created: #1447

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants